From: Borislav Petkov <bp@amd64.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>, Tejun Heo <tj@kernel.org>,
"Petkov, Borislav" <Borislav.Petkov@amd.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: fix section mismatch in reference from native_play_dead
Date: Mon, 14 Feb 2011 14:32:10 +0100 [thread overview]
Message-ID: <20110214133210.GC9137@aftab> (raw)
In-Reply-To: <20110214123244.GA4586@swordfish.minsk.epam.com>
On Mon, Feb 14, 2011 at 07:32:44AM -0500, Sergey Senozhatsky wrote:
> > -int __cpuinit mwait_usable(const struct cpuinfo_x86 *c)
> > +int mwait_usable(const struct cpuinfo_x86 *c)
> > {
> > u32 eax, ebx, ecx, edx;
> >
> >
>
> `int mwait_usable(..)' is called from `void __cpuinit select_idle_routine(...)'
>
> I think we still have section mismatch in this case. Is it correct?
Right, but mwait_usable() is not __cpuinit anymore and __cpuinit
functions should be able to call other functions without annotation,
methinks, no?
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-02-14 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 13:13 [PATCH] x86: fix section mismatch in reference from native_play_dead Sergey Senozhatsky
2011-02-14 12:25 ` Ingo Molnar
2011-02-14 12:32 ` Sergey Senozhatsky
2011-02-14 13:32 ` Borislav Petkov [this message]
2011-02-14 13:52 ` Sergey Senozhatsky
2011-02-14 14:21 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214133210.GC9137@aftab \
--to=bp@amd64.org \
--cc=Borislav.Petkov@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox