From: David Teigland <teigland@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Steven Whitehouse <swhiteho@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] dlm fix for 2.6.38
Date: Mon, 14 Feb 2011 10:38:44 -0500 [thread overview]
Message-ID: <20110214153844.GA6909@redhat.com> (raw)
In-Reply-To: <20110212155100.GR3770@htj.dyndns.org>
On Sat, Feb 12, 2011 at 04:51:00PM +0100, Tejun Heo wrote:
> On Sat, Feb 12, 2011 at 03:44:35PM +0000, Steven Whitehouse wrote:
> > What is the issue here? If there is a problem with the workqueues then
> > we should ask Tejun about it,
>
> Yeah, what kind of problem was it? There's only one work per
> connection so reordering is not a problem. All the workqueue
> operations use proper locking, so the conversion seemed safe to me.
> What am I missing?
find_lkb seems to be getting an actual, but wrong lkid, so it's returning
the wrong lkb in the receive routines. It happens fairly quickly with
multiple wq threads, but not at all with single. One suspect I'm going to
look at are the ls_stub and fields in the lockspace struct. I'm not
convinced extra send/recv threads give us that much benefit in practice,
so it's not my top priority at the moment.
Dave
next prev parent reply other threads:[~2011-02-14 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 23:38 [GIT PULL] dlm fix for 2.6.38 David Teigland
2011-02-12 15:44 ` Steven Whitehouse
2011-02-12 15:51 ` Tejun Heo
2011-02-14 15:38 ` David Teigland [this message]
2011-02-14 15:46 ` Tejun Heo
2011-02-14 16:21 ` David Teigland
2011-02-14 16:24 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214153844.GA6909@redhat.com \
--to=teigland@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swhiteho@redhat.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox