* [PATCH] of: Add missing of_address.h to xilinx ehci driver
@ 2011-02-14 10:40 Michal Simek
2011-02-14 13:54 ` Grant Likely
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Michal Simek @ 2011-02-14 10:40 UTC (permalink / raw)
To: glikely; +Cc: devicetree-discuss, linux-kernel, Michal Simek, John Williams
Build log:
In file included from drivers/usb/host/ehci-hcd.c:1208:
drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':
drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of function 'of_address_to_resource'
Signed-off-by: John Williams <john.williams@petalogix.com>
Signed-off-by: Michal Simek <monstr@monstr.eu>
---
drivers/usb/host/ehci-xilinx-of.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
index e8f4f36..a6f21b8 100644
--- a/drivers/usb/host/ehci-xilinx-of.c
+++ b/drivers/usb/host/ehci-xilinx-of.c
@@ -29,6 +29,7 @@
#include <linux/of.h>
#include <linux/of_platform.h>
+#include <linux/of_address.h>
/**
* ehci_xilinx_of_setup - Initialize the device for ehci_reset()
--
1.5.5.6
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] of: Add missing of_address.h to xilinx ehci driver
2011-02-14 10:40 [PATCH] of: Add missing of_address.h to xilinx ehci driver Michal Simek
@ 2011-02-14 13:54 ` Grant Likely
2011-02-14 15:23 ` Greg KH
[not found] ` <AANLkTikwaUVs_a_eetGjCj=Tg9qSPKAgxKac11gHWqDe@mail.gmail.com>
2011-02-15 20:40 ` Grant Likely
2 siblings, 1 reply; 6+ messages in thread
From: Grant Likely @ 2011-02-14 13:54 UTC (permalink / raw)
To: Michal Simek, Greg Kroah-Hartman
Cc: devicetree-discuss, linux-kernel, John Williams
On Mon, Feb 14, 2011 at 3:40 AM, Michal Simek <monstr@monstr.eu> wrote:
> Build log:
> In file included from drivers/usb/host/ehci-hcd.c:1208:
> drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':
> drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of function 'of_address_to_resource'
>
> Signed-off-by: John Williams <john.williams@petalogix.com>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Greg, let me know if you want me to pick this one up for my next pull req.
g.
> ---
> drivers/usb/host/ehci-xilinx-of.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> index e8f4f36..a6f21b8 100644
> --- a/drivers/usb/host/ehci-xilinx-of.c
> +++ b/drivers/usb/host/ehci-xilinx-of.c
> @@ -29,6 +29,7 @@
>
> #include <linux/of.h>
> #include <linux/of_platform.h>
> +#include <linux/of_address.h>
>
> /**
> * ehci_xilinx_of_setup - Initialize the device for ehci_reset()
> --
> 1.5.5.6
>
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] of: Add missing of_address.h to xilinx ehci driver
2011-02-14 13:54 ` Grant Likely
@ 2011-02-14 15:23 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2011-02-14 15:23 UTC (permalink / raw)
To: Grant Likely
Cc: Michal Simek, devicetree-discuss, linux-kernel, John Williams
On Mon, Feb 14, 2011 at 06:54:08AM -0700, Grant Likely wrote:
> On Mon, Feb 14, 2011 at 3:40 AM, Michal Simek <monstr@monstr.eu> wrote:
> > Build log:
> > In file included from drivers/usb/host/ehci-hcd.c:1208:
> > drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':
> > drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of function 'of_address_to_resource'
> >
> > Signed-off-by: John Williams <john.williams@petalogix.com>
> > Signed-off-by: Michal Simek <monstr@monstr.eu>
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
>
> Greg, let me know if you want me to pick this one up for my next pull req.
Sure, please do that, it makes a bit more sense for you to take it if
you need to.
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <AANLkTikwaUVs_a_eetGjCj=Tg9qSPKAgxKac11gHWqDe@mail.gmail.com>]
* Re: Fwd: [PATCH] of: Add missing of_address.h to xilinx ehci driver
[not found] ` <AANLkTikwaUVs_a_eetGjCj=Tg9qSPKAgxKac11gHWqDe@mail.gmail.com>
@ 2011-02-14 15:56 ` Harry Wei
0 siblings, 0 replies; 6+ messages in thread
From: Harry Wei @ 2011-02-14 15:56 UTC (permalink / raw)
To: devicetree-discuss, greg, john.williams, monstr, grant.likely
Cc: linux-kernel
On Mon, Feb 14, 2011 at 11:53:13PM +0800, harryxiyou wrote:
> ---------- Forwarded message ----------
> From: Michal Simek <monstr@monstr.eu>
> Date: 2011/2/14
> Subject: [PATCH] of: Add missing of_address.h to xilinx ehci driver
> To: glikely@secretlab.ca
> Cc: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org,
> Michal Simek <monstr@monstr.eu>, John Williams <john.williams@petalogix.com>
>
>
> Build log:
> In file included from drivers/usb/host/ehci-hcd.c:1208:
> drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':
> drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of
> function 'of_address_to_resource'
>
> Signed-off-by: John Williams <john.williams@petalogix.com>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
Acked-by: Harry Wei <harryxiyou@gmail.com>
> ---
> drivers/usb/host/ehci-xilinx-of.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-xilinx-of.c
> b/drivers/usb/host/ehci-xilinx-of.c
> index e8f4f36..a6f21b8 100644
> --- a/drivers/usb/host/ehci-xilinx-of.c
> +++ b/drivers/usb/host/ehci-xilinx-of.c
> @@ -29,6 +29,7 @@
>
> #include <linux/of.h>
> #include <linux/of_platform.h>
> +#include <linux/of_address.h>
>
> /**
> * ehci_xilinx_of_setup - Initialize the device for ehci_reset()
> --
> 1.5.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
> --
> Best Regards.
> Harry Wei.
> Do what u like!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] of: Add missing of_address.h to xilinx ehci driver
2011-02-14 10:40 [PATCH] of: Add missing of_address.h to xilinx ehci driver Michal Simek
2011-02-14 13:54 ` Grant Likely
[not found] ` <AANLkTikwaUVs_a_eetGjCj=Tg9qSPKAgxKac11gHWqDe@mail.gmail.com>
@ 2011-02-15 20:40 ` Grant Likely
[not found] ` <AANLkTi=j4COunaLvadkD8Oh2qGaBCsNb8DvrKt_C4GHf@mail.gmail.com>
2 siblings, 1 reply; 6+ messages in thread
From: Grant Likely @ 2011-02-15 20:40 UTC (permalink / raw)
To: Michal Simek; +Cc: glikely, devicetree-discuss, linux-kernel, John Williams
On Mon, Feb 14, 2011 at 11:40:09AM +0100, Michal Simek wrote:
> Build log:
> In file included from drivers/usb/host/ehci-hcd.c:1208:
> drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':
> drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of function 'of_address_to_resource'
>
> Signed-off-by: John Williams <john.williams@petalogix.com>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
Applied, thanks.
g.
> ---
> drivers/usb/host/ehci-xilinx-of.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> index e8f4f36..a6f21b8 100644
> --- a/drivers/usb/host/ehci-xilinx-of.c
> +++ b/drivers/usb/host/ehci-xilinx-of.c
> @@ -29,6 +29,7 @@
>
> #include <linux/of.h>
> #include <linux/of_platform.h>
> +#include <linux/of_address.h>
>
> /**
> * ehci_xilinx_of_setup - Initialize the device for ehci_reset()
> --
> 1.5.5.6
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-02-16 5:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-14 10:40 [PATCH] of: Add missing of_address.h to xilinx ehci driver Michal Simek
2011-02-14 13:54 ` Grant Likely
2011-02-14 15:23 ` Greg KH
[not found] ` <AANLkTikwaUVs_a_eetGjCj=Tg9qSPKAgxKac11gHWqDe@mail.gmail.com>
2011-02-14 15:56 ` Fwd: " Harry Wei
2011-02-15 20:40 ` Grant Likely
[not found] ` <AANLkTi=j4COunaLvadkD8Oh2qGaBCsNb8DvrKt_C4GHf@mail.gmail.com>
2011-02-16 5:55 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox