From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755978Ab1BNQVY (ORCPT ); Mon, 14 Feb 2011 11:21:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21079 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755940Ab1BNQVW (ORCPT ); Mon, 14 Feb 2011 11:21:22 -0500 Date: Mon, 14 Feb 2011 11:21:15 -0500 From: David Teigland To: Tejun Heo Cc: Steven Whitehouse , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] dlm fix for 2.6.38 Message-ID: <20110214162115.GB6909@redhat.com> References: <20110211233844.GC30276@redhat.com> <1297525475.2584.1.camel@dolmen> <20110212155100.GR3770@htj.dyndns.org> <20110214153844.GA6909@redhat.com> <20110214154601.GS18742@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110214154601.GS18742@htj.dyndns.org> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 14, 2011 at 04:46:01PM +0100, Tejun Heo wrote: > Hello, > > On Mon, Feb 14, 2011 at 10:38:44AM -0500, David Teigland wrote: > > find_lkb seems to be getting an actual, but wrong lkid, so it's returning > > the wrong lkb in the receive routines. It happens fairly quickly with > > multiple wq threads, but not at all with single. One suspect I'm going to > > look at are the ls_stub and fields in the lockspace struct. I'm not > > convinced extra send/recv threads give us that much benefit in practice, > > so it's not my top priority at the moment. > > Hmmm... okay. At any rate, please use alloc[_ordered]_workqueue() > interface. create[_singlethread]_workqueue() will be deprecated soon. Oh, I'll switch to the other API in the patch set for the next merge. Dave