public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: torbenh <torbenh@gmx.de>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>,
	Yong Zhang <yong.zhang0@gmail.com>,
	bharata@linux.vnet.ibm.com, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] Re: autogroup: sched_setscheduler() fails
Date: Tue, 15 Feb 2011 16:46:12 +0100	[thread overview]
Message-ID: <20110215154612.GI3055@siel.b> (raw)
In-Reply-To: <1295270160.30950.96.camel@laptop>

On Mon, Jan 17, 2011 at 02:16:00PM +0100, Peter Zijlstra wrote:
> On Thu, 2011-01-13 at 04:54 +0100, Mike Galbraith wrote:
> > sched, autogroup: fix CONFIG_RT_GROUP_SCHED sched_setscheduler() failure.
> > 
> > If CONFIG_RT_GROUP_SCHED is set, __sched_setscheduler() fails due to autogroup
> > not allocating rt_runtime.  Free unused/unusable rt_se and rt_rq, redirect RT
> > tasks to the root task group, and tell __sched_setscheduler() that it's ok.
> > 
> > Signed-off-by: Mike Galbraith <efault@gmx.de>
> > Reported-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> 
> Thanks, applied!

while this behaviour is certeinly necessary, i think this is a hack.
it fixes the problem for autogroups.
But its not fixed for things which want to control the cfs shares via
normal cgroups. 

why isnt rt_runtime_us residing in a separate (new) subsystem ?


-- 
torben Hohn

  reply	other threads:[~2011-02-15 15:46 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10  9:16 autogroup: sched_setscheduler() fails Bharata B Rao
2011-01-10 10:29 ` [patch] " Mike Galbraith
2011-01-10 10:59   ` Peter Zijlstra
2011-01-10 16:42     ` Mike Galbraith
2011-01-11 17:10       ` Bharata B Rao
2011-01-11 18:48         ` Mike Galbraith
2011-01-12  3:37           ` Bharata B Rao
2011-01-12  5:40             ` Yong Zhang
2011-01-12  6:35               ` Bharata B Rao
2011-01-12  7:24                 ` Mike Galbraith
2011-01-12  8:06                   ` Bharata B Rao
2011-01-12  8:47                     ` Mike Galbraith
2011-01-12  9:26                       ` Bharata B Rao
2011-01-12  6:17             ` Mike Galbraith
2011-01-12  6:42               ` Bharata B Rao
2011-01-12  5:40           ` Mike Galbraith
2011-01-12  6:32             ` Yong Zhang
2011-01-12  8:55               ` Mike Galbraith
2011-01-13  3:54               ` Mike Galbraith
2011-01-13  5:59                 ` Yong Zhang
2011-01-13  6:02                   ` Yong Zhang
2011-01-13  6:13                   ` Mike Galbraith
2011-01-13  8:46                 ` Bharata B Rao
2011-01-17 13:16                 ` Peter Zijlstra
2011-02-15 15:46                   ` torbenh [this message]
2011-02-15 16:43                     ` Mike Galbraith
2011-02-18 11:09                       ` torbenh
2011-02-18 12:50                         ` Mike Galbraith
2011-02-18 13:40                           ` torbenh
2011-02-22 12:24                           ` torbenh
2011-02-22 14:47                             ` Mike Galbraith
2011-02-28 17:53                               ` torbenh
2011-02-28 18:29                                 ` Mike Galbraith
2011-02-28 19:10                                   ` torbenh
2011-03-01  4:02                                     ` Mike Galbraith
2011-03-01  4:21                                       ` Mike Galbraith
2011-03-01 15:59                                         ` torbenh
2011-01-18 19:05                 ` [tip:sched/urgent] sched, autogroup: Fix CONFIG_RT_GROUP_SCHED sched_setscheduler() failure tip-bot for Mike Galbraith
2011-01-12  5:43       ` [patch] Re: autogroup: sched_setscheduler() fails Yong Zhang
2011-01-12  6:25         ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110215154612.GI3055@siel.b \
    --to=torbenh@gmx.de \
    --cc=a.p.zijlstra@chello.nl \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox