From: Greg KH <gregkh@suse.de>
To: Hank Janssen <hjanssen@microsoft.com>
Cc: KY Srinivasan <kys@microsoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
Hashir Abdi <habdi@microsoft.com>,
Mike Sterling <Mike.Sterling@microsoft.com>
Subject: Re: [PATCH ]:Staging: hv: Allocate the vmbus irq dynamically
Date: Tue, 15 Feb 2011 09:22:53 -0800 [thread overview]
Message-ID: <20110215172253.GB18437@suse.de> (raw)
In-Reply-To: <8AFC7968D54FB448A30D8F38F259C56233F9714A@TK5EX14MBXC114.redmond.corp.microsoft.com>
On Tue, Feb 15, 2011 at 04:59:28PM +0000, Hank Janssen wrote:
>
>
> > -----Original Message-----
> > From: KY Srinivasan
> > Sent: Tuesday, February 15, 2011 8:54 AM
> > > -----Original Message-----
> > > From: Greg KH [mailto:gregkh@suse.de]
> > > Sent: Tuesday, February 15, 2011 11:00 AM
> > > To: KY Srinivasan
> > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> > > virtualization@lists.osdl.org; Haiyang Zhang; Hank Janssen
> > > Subject: Re: [PATCH ]:Staging: hv: Allocate the vmbus irq dynamically
> > >
>
> > > And why are you still printing this out for the whole world to see?
> > Greg, this patch addressed a specific comment with regards dynamically
> > allocate the irq.
> > Hank is working on a patch to address the various DPRINTS in the code.
>
> Before the end of the week I will submit two patches for this;
>
> Remove DPRINT and change it to printk
No, use dev_dbg() and friends instead of "raw" printk() calls.
> Remove excessive printouts on startup of vmbus
That would be nice to see. There should be almost nothing outputed by
these drivers on "normal" operation.
thanks,
greg k-h
next prev parent reply other threads:[~2011-02-15 17:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 15:15 [PATCH ]:Staging: hv: Allocate the vmbus irq dynamically K. Y. Srinivasan
2011-02-15 15:59 ` Greg KH
2011-02-15 16:53 ` KY Srinivasan
2011-02-15 16:59 ` Hank Janssen
2011-02-15 17:22 ` Greg KH [this message]
2011-02-15 17:28 ` Hank Janssen
2011-02-15 19:09 ` Hank Janssen
2011-02-15 19:33 ` Greg KH
2011-02-15 17:25 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2011-02-15 19:55 [PATCH]: Staging: " K. Y. Srinivasan
2011-02-18 21:14 ` Greg KH
2011-02-18 22:00 ` KY Srinivasan
2011-02-18 22:07 ` Greg KH
2011-02-18 22:16 ` KY Srinivasan
2011-02-18 22:29 ` Greg KH
2011-02-19 0:56 ` KY Srinivasan
2011-02-19 1:02 ` Greg KH
2011-02-19 1:19 ` KY Srinivasan
2011-02-19 10:23 ` Thomas Gleixner
2011-02-19 14:34 ` KY Srinivasan
2011-02-19 15:12 ` Thomas Gleixner
2011-02-19 16:46 ` KY Srinivasan
2011-02-20 16:15 ` Thomas Gleixner
2011-02-21 3:43 ` KY Srinivasan
2011-02-21 3:50 ` Greg KH
2011-02-21 11:02 ` Thomas Gleixner
2011-02-21 14:40 ` KY Srinivasan
2011-02-21 14:51 ` Thomas Gleixner
2011-02-21 15:43 ` Greg KH
2011-02-23 19:16 ` Greg KH
2011-02-23 19:22 ` KY Srinivasan
2011-02-19 1:26 K. Y. Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110215172253.GB18437@suse.de \
--to=gregkh@suse.de \
--cc=Mike.Sterling@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=habdi@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox