Re: [patch v2 0/3] OProfile support for System z's hardware sampling

[Robert Richter <robert.richter@amd.com>]

On 15.02.11 11:59:29, Heinz Graalfs wrote:

> > * Merge init.c and hwsampler_file.c, two files are bloated here and
> >   hwsampler_file.c is a bad and too long naming.
> > 
> 
> OK, I've merged all hwsampler_files.c contents into init.c
> 
> > * Rework functions in cpu_buffer.c (log_sample,
> >   __oprofile_add_ext_sample, oprofile_add_ext_hw_sample, etc.). All
> >   the (static) functions can be merged to a single functino by
> >   implementing a struct that holds all current function arguments.
> >   Something like:
> > 
> > static void __oprofile_add_ext_sample(struct *foobar fb);
> > void oprofile_add_sample(struct pt_regs * const regs, unsigned long event)
> > {
> > 	struct foobar fb = { .regs = regs, .event = event };
> > 	__oprofile_add_ext_sample(&fb);
> > }
> 
> OK, I've done this
> 
> > 
> >   The naming and description of oprofile_add_ext_hw_sample() is also
> >   not the best. As interface in include/linux/oprofile.h we could then
> >   merge oprofile_add_ext_sample() and oprofile_add_ext_hw_sample() to
> >   a single function.
> > 
> > It would be nice if you could implement this.
> 
> sure, I will do this, however I'm not sure what you exactly mean.
> Could you specify the interface in oprofile.h what you basically have in
> mind?

I mean to replace oprofile_add_ext_sample() and
oprofile_add_ext_hw_sample() by a new one. The interface would be in
the form of:

struct foobar {
       ...
}

static void __oprofile_add_ext_sample(struct *foobar fb);

Hope this makes sense. The advantage would be that we don't need to
extend the functions argument list anymore, we simply extend the
struct.

Please send me delta patches to oprofile/s390.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center