public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: wei_wang@realsil.com.cn
Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts_pstor: fix sparse warning
Date: Tue, 15 Feb 2011 18:09:44 -0800	[thread overview]
Message-ID: <20110216020944.GA29648@suse.de> (raw)
In-Reply-To: <1297820618-11962-1-git-send-email-wei_wang@realsil.com.cn>

On Wed, Feb 16, 2011 at 09:43:38AM +0800, wei_wang@realsil.com.cn wrote:
> From: wwang <wei_wang@realsil.com.cn>
> 
> Add static modifier before some function definitions; delete function
> named rtsx_transfer_sglist which won't be called.

Thanks for describing this better.

And now that we can easily see that you are doing more than one thing in
this patch, please redo it, only doing one-thing-per-patch as is the way
we require patches to be.

Care to resend this as a series of patches?

thanks,

greg k-h

  reply	other threads:[~2011-02-16  2:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16  1:43 [PATCH] staging: rts_pstor: fix sparse warning wei_wang
2011-02-16  2:09 ` Greg KH [this message]
2011-02-16  2:19   ` wwang
2011-02-16 15:49     ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2011-02-15  1:15 wei_wang
2011-02-15 12:21 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110216020944.GA29648@suse.de \
    --to=gregkh@suse.de \
    --cc=devel@linuxdriverproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wei_wang@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox