From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: please, remove the abuse of vfs_path_lookup() in ecryptfs
Date: Thu, 17 Feb 2011 01:53:50 +0000 [thread overview]
Message-ID: <20110217015350.GH22723@ZenIV.linux.org.uk> (raw)
commit 21edad32205e97dc7ccb81a85234c77e760364c8 (
ecryptfs: dont call lookup_one_len to avoid NULL nameidata) is badly
misguided. The last thing we need is extra places where nameidata is
passed around.
The current code is simply wrong - it's bypassing dcache
lookups in new_lower_dentry(). Besides, abuse of vfs_path_lookup()
here is a Bad Idea(tm). No, filesystems are *not* allowed to die
if ->d_revalidate()/->lookup()/->create() are called with NULL
nameidata. Eventually these methods will lose nameidata * anyway -
starting with ->d_revalidate() in the next cycle at the latest
(i.e. if we run into something really stinky in RCU mess, it might
happen before -final).
Please revert that.
next reply other threads:[~2011-02-17 1:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 1:53 Al Viro [this message]
2011-02-18 3:45 ` please, remove the abuse of vfs_path_lookup() in ecryptfs Tyler Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217015350.GH22723@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tyhicks@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox