From: Arnd Bergmann <arnd@arndb.de>
To: John Linn <John.Linn@xilinx.com>
Cc: Jamie Iles <jamie@jamieiles.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
catalin.marinas@arm.com, glikely@secretlab.ca
Subject: Re: [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros
Date: Thu, 17 Feb 2011 15:41:11 +0100 [thread overview]
Message-ID: <201102171541.12261.arnd@arndb.de> (raw)
In-Reply-To: <71326bcb-7836-4820-84c1-f3d8257e9f92@VA3EHSMHS020.ehs.local>
On Thursday 17 February 2011, John Linn wrote:
> > > +
> > > +#define UART_FIFO_WRITE(base, value) \
> > > + (*(volatile unsigned int *)((base) + UART_FIFO_OFFSET) =
> (value))
> > > +
> > > +#define UART_STATUS(base) \
> > > + (*(volatile unsigned int *)((base) + UART_SR_OFFSET))
> >
> > You could probably make these static inline functions in the header
> and
> > use __raw_{readl,writel}() to make this a little cleaner.
> >
>
> I had considered that, but it wasn't clear to me at the time what the
> compressor could use or not.
>
> I'll give it a try as I agree that's cleaner.
Actually, for correctness you should use the regular readl/writel, not
the __raw_ versions, which can result in reordered or partial accesses
on the bus.
Arnd
next prev parent reply other threads:[~2011-02-17 14:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1297872716-13353-1-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 1/4] ARM: Xilinx: Adding Xilinx board support John Linn
2011-02-17 9:34 ` Jamie Iles
2011-02-17 14:24 ` John Linn
[not found] ` <1297872716-13353-2-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 2/4] ARM: Xilinx: Adding timer support to the platform John Linn
2011-02-17 9:48 ` Jamie Iles
2011-02-17 14:27 ` John Linn
[not found] ` <1297872716-13353-3-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros John Linn
2011-02-17 10:01 ` Jamie Iles
2011-02-17 14:31 ` John Linn
2011-02-17 14:41 ` Arnd Bergmann [this message]
2011-02-17 15:12 ` Russell King - ARM Linux
2011-02-17 15:18 ` Arnd Bergmann
2011-02-17 21:58 ` Stephen Boyd
2011-02-18 1:29 ` John Linn
2011-02-18 0:37 ` John Linn
2011-02-18 0:45 ` Jamie Iles
2011-02-18 1:19 ` John Linn
2011-02-18 9:06 ` Jamie Iles
2011-02-18 13:59 ` John Linn
2011-02-18 14:28 ` John Linn
[not found] ` <1297872716-13353-4-git-send-email-john.linn@xilinx.com>
2011-02-16 16:11 ` [PATCH V3 4/4] ARM: Xilinx: Adding Xilinx platform infrastructure support John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102171541.12261.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=John.Linn@xilinx.com \
--cc=catalin.marinas@arm.com \
--cc=glikely@secretlab.ca \
--cc=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox