From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Steven Rostedt <srostedt@redhat.com>,
Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>
Subject: Re: [PATCH] gpio: add trace events for setting direction and value
Date: Fri, 18 Feb 2011 10:58:03 +0100 [thread overview]
Message-ID: <20110218095803.GY22310@pengutronix.de> (raw)
In-Reply-To: <1297876371.26768.7235.camel@fedora>
Hi Steven, hi Grant,
On Wed, Feb 16, 2011 at 12:12:51PM -0500, Steven Rostedt wrote:
> Note: to save the memory footprint of these tracepoints, you can use
> DEFINE_EVENT_PRINT(). You can see the usage for this in the
> include/trace/events/kmem.h.
> But to do this, you will need to have a single TP_STRUCT__entry() for
> both. Not sure if this is what you want.
>
> TP_STRUCT__entry(
> __field(unsigned, gpiq)
> __field(int, get_in)
> __field(int, value_err)
>
> ??
>
> Just a suggestion, but may not be worth it.
Yeah, I saw that, still I think it's sane to keep them seperated.
Or how much would we save? Can you estimate that?
@Grant: Steven told me this should go via your tree, so if you are OK
with the change, feel free to take it.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-02-18 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 17:03 [PATCH] gpio: add trace events for setting direction and value Uwe Kleine-König
2011-02-16 17:12 ` Steven Rostedt
2011-02-18 9:58 ` Uwe Kleine-König [this message]
2011-02-18 15:48 ` Steven Rostedt
2011-03-02 22:03 ` Grant Likely
2011-04-26 15:04 ` Uwe Kleine-König
2011-05-19 18:16 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110218095803.GY22310@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).