From: Arnd Bergmann <arnd@arndb.de>
To: John Linn <John.Linn@xilinx.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
catalin.marinas@arm.com, glikely@secretlab.ca,
jamie@jamieiles.com
Subject: Re: [PATCH V4 3/4] ARM: Xilinx: base header files and assembly macros
Date: Mon, 21 Feb 2011 09:36:41 +0100 [thread overview]
Message-ID: <201102210936.42098.arnd@arndb.de> (raw)
In-Reply-To: <c170bbf2-ac0a-4c55-b2a7-0215c7a79635@VA3EHSMHS032.ehs.local>
On Monday 21 February 2011, John Linn wrote:
> > > diff --git a/arch/arm/mach-xilinx/include/mach/timex.h
> > b/arch/arm/mach-xilinx/include/mach/timex.h
> > > new file mode 100644
> > > index 0000000..4ebc0a6
> > > --- /dev/null
> > > +++ b/arch/arm/mach-xilinx/include/mach/timex.h
> > > +#ifndef __MACH_TIMEX_H__
> > > +#define __MACH_TIMEX_H__
> > > +
> > > +#define PERIPHERAL_CLOCK_RATE 2500000
> > > +
> > > +#define CLOCK_TICK_RATE (PERIPHERAL_CLOCK_RATE / 32)
> > > +
> > > +#endif
> >
> > I thought we were at the point where CLOCK_TICK_RATE is no longer
> used.
>
> The timer code in these patches is using it, no other comments on it so
> far.
>
> > Did the patches not make it in yet?
> >
>
> I haven't heard they made them in yet, just waiting and hoping for an
> ack.
I meant the patches removing CLOCK_TICK_RATE from common code, not your
patches, sorry for being vague.
It would be better if you could avoid introducing new uses of
CLOCK_TICK_RATE, because that will have to be removed before we can
move to a real multi-platform kernel. For instance, you can put
PERIPHERAL_CLOCK_RATE in a hardware specific header and put a bogus
definition for CLOCK_TICK_RATE into timex.h
Arnd
next prev parent reply other threads:[~2011-02-21 8:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1298052881-14591-1-git-send-email-john.linn@xilinx.com>
2011-02-18 18:14 ` [PATCH V4 1/4] ARM: Xilinx: Adding Xilinx board support John Linn
2011-02-28 11:06 ` Jamie Iles
2011-02-28 14:13 ` John Linn
[not found] ` <1298052881-14591-2-git-send-email-john.linn@xilinx.com>
2011-02-18 18:14 ` [PATCH V4 2/4] ARM: Xilinx: Adding timer support to the platform John Linn
2011-02-28 11:11 ` Jamie Iles
2011-02-28 14:14 ` John Linn
[not found] ` <1298052881-14591-3-git-send-email-john.linn@xilinx.com>
2011-02-18 18:14 ` [PATCH V4 3/4] ARM: Xilinx: base header files and assembly macros John Linn
2011-02-20 21:37 ` Arnd Bergmann
2011-02-21 0:18 ` John Linn
2011-02-21 8:36 ` Arnd Bergmann [this message]
2011-02-21 14:36 ` John Linn
2011-02-21 14:48 ` Arnd Bergmann
2011-02-21 15:04 ` John Linn
2011-02-21 15:17 ` Russell King - ARM Linux
2011-02-21 21:08 ` CLOCK_TICK_RATE, was: " Arnd Bergmann
2011-02-21 21:51 ` Thomas Gleixner
2011-02-28 11:18 ` Jamie Iles
2011-02-28 14:20 ` John Linn
2011-02-28 15:01 ` Jamie Iles
2011-02-28 11:20 ` Russell King - ARM Linux
2011-02-28 14:22 ` [PATCH V4 3/4] ARM: Xilinx: base header files and assemblymacros John Linn
[not found] ` <1298052881-14591-4-git-send-email-john.linn@xilinx.com>
2011-02-18 18:14 ` [PATCH V4 4/4] ARM: Xilinx: Adding Xilinx platform infrastructure support John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102210936.42098.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=John.Linn@xilinx.com \
--cc=catalin.marinas@arm.com \
--cc=glikely@secretlab.ca \
--cc=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox