From: NeilBrown <neilb@suse.de>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Andrew Patterson <andrew.patterson@hp.com>,
Jens Axboe <axboe@kernel.dk>,
linux-raid@vger.kernel.org, dm-devel@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix over-zealous flush_disk when changing device size.
Date: Tue, 22 Feb 2011 08:14:43 +1100 [thread overview]
Message-ID: <20110222081443.6ec89942@notabene.brown> (raw)
In-Reply-To: <x49hbbx18pq.fsf@segfault.boston.devel.redhat.com>
On Mon, 21 Feb 2011 14:36:01 -0500 Jeff Moyer <jmoyer@redhat.com> wrote:
> NeilBrown <neilb@suse.de> writes:
>
> > -int __invalidate_device(struct block_device *bdev)
> > +int __invalidate_device2(struct block_device *bdev, bool kill_dirty)
> > {
> > struct super_block *sb = get_super(bdev);
> > int res = 0;
> > @@ -1614,7 +1614,7 @@ int __invalidate_device(struct block_device *bdev)
> > * hold).
> > */
> > shrink_dcache_sb(sb);
> > - res = invalidate_inodes(sb);
> > + res = invalidate_inodes(sb, kill_dirty);
> > drop_super(sb);
> > }
> > invalidate_bdev(bdev);
>
> Neil, I think you also need to change the EXPORT_SYMBOL from
> __invalidate_device to __invalidate_device2. The floppy module won't
> build without that change.
Good point, thank.
I've just made this change in mt for-next tree so it should appear in -next
today?
NeilBrown
next prev parent reply other threads:[~2011-02-21 21:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 5:50 [PATCH] Fix over-zealous flush_disk when changing device size NeilBrown
2011-02-17 17:03 ` Jeff Moyer
2011-02-21 19:36 ` Jeff Moyer
2011-02-21 21:14 ` NeilBrown [this message]
2011-03-03 14:31 ` Christoph Hellwig
2011-03-04 0:16 ` NeilBrown
2011-03-04 17:25 ` Andrew Patterson
2011-03-06 6:47 ` NeilBrown
2011-03-07 4:22 ` Andrew Patterson
2011-03-07 16:46 ` [dm-devel] " James Bottomley
2011-03-07 22:44 ` NeilBrown
2011-03-07 22:56 ` James Bottomley
2011-03-08 0:04 ` NeilBrown
2011-03-16 20:30 ` Jeff Moyer
2011-03-17 1:28 ` NeilBrown
2011-03-17 17:33 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222081443.6ec89942@notabene.brown \
--to=neilb@suse.de \
--cc=andrew.patterson@hp.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).