From: Dan Carpenter <error27@gmail.com>
To: Dirk Eibach <eibach@gdsys.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: Fix wrong pointer type in pca953x
Date: Tue, 22 Feb 2011 15:36:01 +0300 [thread overview]
Message-ID: <20110222123601.GA1966@bicker> (raw)
In-Reply-To: <1298365010-22951-1-git-send-email-eibach@gdsys.de>
On Tue, Feb 22, 2011 at 09:56:50AM +0100, Dirk Eibach wrote:
> struct pca953x_platform_data *pdata;
> struct device_node *node;
> - const uint16_t *val;
> + const u32 *val;
>
This should probably be signed? We compare it against zero later on.
if (*val < 0)
dev_warn(&client->dev,
"invalid gpio-base in device tree\n");
regards,
dan carpenter
next prev parent reply other threads:[~2011-02-22 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 8:56 [PATCH] gpio: Fix wrong pointer type in pca953x Dirk Eibach
2011-02-22 12:36 ` Dan Carpenter [this message]
2011-02-22 12:52 ` Eibach, Dirk
2011-02-22 13:28 ` [PATCH v2] " Dirk Eibach
2011-02-24 9:20 ` [PATCH v3] " Dirk Eibach
2011-02-24 15:56 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222123601.GA1966@bicker \
--to=error27@gmail.com \
--cc=eibach@gdsys.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox