From: Yong Zhang <yong.zhang0@gmail.com>
To: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH V2] sched, autogroup: always show autogroup name in sched_debug
Date: Tue, 22 Feb 2011 22:32:59 +0800 [thread overview]
Message-ID: <20110222143259.GA1578@zhy> (raw)
In-Reply-To: <1298383320.8036.5.camel@marge.simson.net>
On Tue, Feb 22, 2011 at 03:02:00PM +0100, Mike Galbraith wrote:
> On Tue, 2011-02-22 at 20:10 +0800, Yong Zhang wrote:
> > On Tue, Feb 22, 2011 at 10:56:06AM +0100, Peter Zijlstra wrote:
> > > On Tue, 2011-02-22 at 11:13 +0800, Yong Zhang wrote:
> > > > So show autogroup name always. But for the root group,
> > > > its name will dance between "cfs_rq[cpu]:" and
> > > > "cfs_rq[cpu]:/autogroup-0" according to
> > > > sysctl_sched_autogroup_enabled.
> > >
> > > Would it make sense to force the root group to always be a !autogroup?
> >
> > Hmmm, I think it's ok.
>
> Yup, it's not an autogroup, so let's stop claiming it.
>
> sched, autogroup: stop claiming ownership of the root task group.
>
> Disown it, and only display autogroup association if one exists.
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
Ah, I like this one better :)
Actually I misunderstanded what Peter mean.
Reviewed-by: Yong Zhang <yong.zhang0@gmail.com>
Thanks,
Yong
>
> diff --git a/kernel/sched_autogroup.c b/kernel/sched_autogroup.c
> index 9fb6562..506faa0 100644
> --- a/kernel/sched_autogroup.c
> +++ b/kernel/sched_autogroup.c
> @@ -12,7 +12,6 @@ static atomic_t autogroup_seq_nr;
> static void __init autogroup_init(struct task_struct *init_task)
> {
> autogroup_default.tg = &root_task_group;
> - root_task_group.autogroup = &autogroup_default;
> kref_init(&autogroup_default.kref);
> init_rwsem(&autogroup_default.lock);
> init_task->signal->autogroup = &autogroup_default;
> @@ -130,7 +129,7 @@ task_wants_autogroup(struct task_struct *p, struct task_group *tg)
>
> static inline bool task_group_is_autogroup(struct task_group *tg)
> {
> - return tg != &root_task_group && tg->autogroup;
> + return !!tg->autogroup;
> }
>
> static inline struct task_group *
> @@ -247,10 +246,14 @@ void proc_sched_autogroup_show_task(struct task_struct *p, struct seq_file *m)
> {
> struct autogroup *ag = autogroup_task_get(p);
>
> + if (!task_group_is_autogroup(ag->tg))
> + goto out;
> +
> down_read(&ag->lock);
> seq_printf(m, "/autogroup-%ld nice %d\n", ag->id, ag->nice);
> up_read(&ag->lock);
>
> +out:
> autogroup_kref_put(ag);
> }
> #endif /* CONFIG_PROC_FS */
> @@ -258,9 +261,7 @@ void proc_sched_autogroup_show_task(struct task_struct *p, struct seq_file *m)
> #ifdef CONFIG_SCHED_DEBUG
> static inline int autogroup_path(struct task_group *tg, char *buf, int buflen)
> {
> - int enabled = ACCESS_ONCE(sysctl_sched_autogroup_enabled);
> -
> - if (!enabled || !tg->autogroup)
> + if (!task_group_is_autogroup(tg))
> return 0;
>
> return snprintf(buf, buflen, "%s-%ld", "/autogroup", tg->autogroup->id);
>
next prev parent reply other threads:[~2011-02-22 14:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 7:08 [PATCH 0/5] autogroup runtime enable/disable tuning fix Yong Zhang
2011-02-20 7:08 ` [PATCH 1/5] sched, autogroup, sysctl: use proc_dointvec_minmax instead Yong Zhang
2011-02-23 12:05 ` [tip:sched/core] sched, autogroup, sysctl: Use proc_dointvec_minmax() instead tip-bot for Yong Zhang
2011-02-20 7:08 ` [PATCH 2/5] sched: hide cfs_rq of autogroup if autogroup is disabled Yong Zhang
2011-02-20 7:08 ` [PATCH 3/5] sched, autogroup: stop going ahead " Yong Zhang
2011-02-23 12:05 ` [tip:sched/core] sched, autogroup: Stop " tip-bot for Yong Zhang
2011-02-20 7:08 ` [PATCH 4/5] sched: refactor task_group() Yong Zhang
2011-02-20 7:08 ` [PATCH 5/5] sched, autogroup: runtime enable/disable tuning fix Yong Zhang
2011-02-20 13:09 ` Mike Galbraith
2011-02-20 14:10 ` Yong Zhang
2011-02-20 17:22 ` Mike Galbraith
2011-02-21 3:13 ` Mike Galbraith
2011-02-21 9:05 ` Yong Zhang
2011-02-21 16:36 ` Peter Zijlstra
2011-02-21 21:12 ` Ingo Molnar
2011-02-22 3:13 ` Yong Zhang
2011-02-22 9:56 ` Peter Zijlstra
2011-02-22 12:10 ` [PATCH V2] sched, autogroup: always show autogroup name in sched_debug Yong Zhang
2011-02-22 14:02 ` Mike Galbraith
2011-02-22 14:32 ` Yong Zhang [this message]
2011-02-23 12:06 ` [tip:sched/core] sched, autogroup: Stop claiming ownership of the root task group tip-bot for Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222143259.GA1578@zhy \
--to=yong.zhang0@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox