From: Arnd Bergmann <arnd@arndb.de>
To: "Guan Xuetao" <gxt@mprc.pku.edu.cn>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
"'Greg KH'" <greg@kroah.com>
Subject: Re: [PATCHv2 09/11] unicore32 core architecture: timer and time handling
Date: Tue, 22 Feb 2011 16:21:07 +0100 [thread overview]
Message-ID: <201102221621.07655.arnd@arndb.de> (raw)
In-Reply-To: <018c01cbd29b$759a4740$60ced5c0$@mprc.pku.edu.cn>
On Tuesday 22 February 2011, Guan Xuetao wrote:
> > > +#if defined(CONFIG_PUV3_DB0913) \
> > > + || defined(CONFIG_PUV3_NB0916) \
> > > + || defined(CONFIG_PUV3_SMW0919)
> > > +
> > > +#define CLOCK_TICK_RATE (14318000)
> > > +
> > > +#endif
> >
> > I believe that we don't use CLOCK_TICK_RATE in the kernel any more,
> > so there is no reason to define it.
> CLOCK_TICK_RATE is an important value for the kernel.
> And perhaps I misunderstanding your meaning...
We just discussed the same thing for a new ARM platform. You are
right that CLOCK_TICK_RATE is currently still being used, but
we are trying to get rid of it.
Most importantly, it should not be configuration specific any more.
If you use CLOCK_TICK_RATE in unicore32 specific code, it would
be best to rename that variable and device it in a board specific
file.
The definition in timex.h can basically contain any value that is
a multiple of CONFIG_HZ. Don't worry about this one, we will fix
it for good for the entire kernel.
Arnd
next prev parent reply other threads:[~2011-02-22 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 6:39 [PATCHv2 09/11] unicore32 core architecture: timer and time handling Guan Xuetao
2011-02-16 9:20 ` Thomas Gleixner
2011-02-17 9:58 ` Guan Xuetao
2011-02-17 10:47 ` Thomas Gleixner
2011-02-17 11:09 ` Guan Xuetao
2011-02-17 17:31 ` Arnd Bergmann
2011-02-22 14:19 ` Guan Xuetao
2011-02-22 15:21 ` Arnd Bergmann [this message]
2011-02-27 4:34 ` Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102221621.07655.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox