Re: [PATCH 3/8] Preserve local node for KSM copies

Andi Kleen
2011-02-22T18:24:16Z

On Tue, Feb 22, 2011 at 09:47:26AM -0600, Christoph Lameter wrote:
> On Mon, 21 Feb 2011, Andi Kleen wrote:
>
> > Add a alloc_page_vma_node that allows passing the "local" node in.
> > Use it in ksm to allocate copy pages on the same node as
> > the original as possible.
>
> Why would that be useful? The shared page could be on a node that is not
> near the process that maps the page. Would it not be better to allocate on
> the node that is local to the process that maps the page?

Either could be wrong, but not moving the mappings seems most deterministic
to me. At least one of the processes (whoever allocated the page first)
will stay with its local memory.

Also the alloc_page_vma_node() call is used for THP too. I guess i should
split it out.

-Andi