From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] perf lock: show valid sort keys in usage
Date: Tue, 22 Feb 2011 15:01:10 -0300 [thread overview]
Message-ID: <20110222180110.GG27070@ghostprotocols.net> (raw)
In-Reply-To: <20110222174557.GB9687@joi.lan>
Em Tue, Feb 22, 2011 at 06:45:57PM +0100, Marcin Slusarz escreveu:
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> ---
> tools/perf/builtin-lock.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index 2b36def..0305a40 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -893,7 +893,7 @@ static const char * const report_usage[] = {
>
> static const struct option report_options[] = {
> OPT_STRING('k', "key", &sort_key, "acquired",
> - "key for sorting"),
> + "key for sorting (acquired / contended / wait_total / wait_max / wait_min)"),
> /* TODO: type */
> OPT_END()
> };
Can you please add to tools/perf/Documentation/perf-lock.txt too?
Thanks,
- Arnaldo
next prev parent reply other threads:[~2011-02-22 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 17:45 [PATCH] perf lock: show valid sort keys in usage Marcin Slusarz
2011-02-22 18:01 ` Arnaldo Carvalho de Melo [this message]
2011-02-22 20:53 ` Marcin Slusarz
2011-02-23 14:52 ` [tip:perf/core] perf lock: Document valid sort keys tip-bot for Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222180110.GG27070@ghostprotocols.net \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox