* [PATCH] perf lock: show valid sort keys in usage @ 2011-02-22 17:45 Marcin Slusarz 2011-02-22 18:01 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 4+ messages in thread From: Marcin Slusarz @ 2011-02-22 17:45 UTC (permalink / raw) To: LKML; +Cc: Peter Zijlstra, Arnaldo Carvalho de Melo, Paul Mackerras, Ingo Molnar Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> --- tools/perf/builtin-lock.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c index 2b36def..0305a40 100644 --- a/tools/perf/builtin-lock.c +++ b/tools/perf/builtin-lock.c @@ -893,7 +893,7 @@ static const char * const report_usage[] = { static const struct option report_options[] = { OPT_STRING('k', "key", &sort_key, "acquired", - "key for sorting"), + "key for sorting (acquired / contended / wait_total / wait_max / wait_min)"), /* TODO: type */ OPT_END() }; -- 1.7.4.rc3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] perf lock: show valid sort keys in usage 2011-02-22 17:45 [PATCH] perf lock: show valid sort keys in usage Marcin Slusarz @ 2011-02-22 18:01 ` Arnaldo Carvalho de Melo 2011-02-22 20:53 ` Marcin Slusarz 0 siblings, 1 reply; 4+ messages in thread From: Arnaldo Carvalho de Melo @ 2011-02-22 18:01 UTC (permalink / raw) To: Marcin Slusarz; +Cc: LKML, Peter Zijlstra, Paul Mackerras, Ingo Molnar Em Tue, Feb 22, 2011 at 06:45:57PM +0100, Marcin Slusarz escreveu: > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> > --- > tools/perf/builtin-lock.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c > index 2b36def..0305a40 100644 > --- a/tools/perf/builtin-lock.c > +++ b/tools/perf/builtin-lock.c > @@ -893,7 +893,7 @@ static const char * const report_usage[] = { > > static const struct option report_options[] = { > OPT_STRING('k', "key", &sort_key, "acquired", > - "key for sorting"), > + "key for sorting (acquired / contended / wait_total / wait_max / wait_min)"), > /* TODO: type */ > OPT_END() > }; Can you please add to tools/perf/Documentation/perf-lock.txt too? Thanks, - Arnaldo ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf lock: show valid sort keys in usage 2011-02-22 18:01 ` Arnaldo Carvalho de Melo @ 2011-02-22 20:53 ` Marcin Slusarz 2011-02-23 14:52 ` [tip:perf/core] perf lock: Document valid sort keys tip-bot for Marcin Slusarz 0 siblings, 1 reply; 4+ messages in thread From: Marcin Slusarz @ 2011-02-22 20:53 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: LKML, Peter Zijlstra, Paul Mackerras, Ingo Molnar On Tue, Feb 22, 2011 at 03:01:10PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Feb 22, 2011 at 06:45:57PM +0100, Marcin Slusarz escreveu: > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> > > --- > > tools/perf/builtin-lock.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c > > index 2b36def..0305a40 100644 > > --- a/tools/perf/builtin-lock.c > > +++ b/tools/perf/builtin-lock.c > > @@ -893,7 +893,7 @@ static const char * const report_usage[] = { > > > > static const struct option report_options[] = { > > OPT_STRING('k', "key", &sort_key, "acquired", > > - "key for sorting"), > > + "key for sorting (acquired / contended / wait_total / wait_max / wait_min)"), > > /* TODO: type */ > > OPT_END() > > }; > > Can you please add to tools/perf/Documentation/perf-lock.txt too? Sure. --- From: Marcin Slusarz <marcin.slusarz@gmail.com> Subject: [PATCH] perf lock: document valid sort keys Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> --- tools/perf/Documentation/perf-lock.txt | 12 ++++++++++-- tools/perf/builtin-lock.c | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/Documentation/perf-lock.txt b/tools/perf/Documentation/perf-lock.txt index 921de25..4d3314b 100644 --- a/tools/perf/Documentation/perf-lock.txt +++ b/tools/perf/Documentation/perf-lock.txt @@ -24,8 +24,8 @@ and statistics with this 'perf lock' command. 'perf lock report' reports statistical data. -OPTIONS -------- +COMMON OPTIONS +-------------- -i:: --input=<file>:: @@ -39,6 +39,14 @@ OPTIONS --dump-raw-trace:: Dump raw trace in ASCII. +REPORT OPTIONS +-------------- + +-k:: +--key=<value>:: + Sorting key. Possible values: acquired (default), contended, + wait_total, wait_max, wait_min. + SEE ALSO -------- linkperf:perf[1] diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c index 2b7eb18..812ad26 100644 --- a/tools/perf/builtin-lock.c +++ b/tools/perf/builtin-lock.c @@ -904,7 +904,7 @@ static const char * const report_usage[] = { static const struct option report_options[] = { OPT_STRING('k', "key", &sort_key, "acquired", - "key for sorting"), + "key for sorting (acquired / contended / wait_total / wait_max / wait_min)"), /* TODO: type */ OPT_END() }; -- 1.7.4.rc3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [tip:perf/core] perf lock: Document valid sort keys 2011-02-22 20:53 ` Marcin Slusarz @ 2011-02-23 14:52 ` tip-bot for Marcin Slusarz 0 siblings, 0 replies; 4+ messages in thread From: tip-bot for Marcin Slusarz @ 2011-02-23 14:52 UTC (permalink / raw) To: linux-tip-commits Cc: acme, linux-kernel, paulus, hpa, mingo, a.p.zijlstra, marcin.slusarz, tglx, mingo Commit-ID: 9826e8329bc160e4cc58b83019f3f056965e42d0 Gitweb: http://git.kernel.org/tip/9826e8329bc160e4cc58b83019f3f056965e42d0 Author: Marcin Slusarz <marcin.slusarz@gmail.com> AuthorDate: Tue, 22 Feb 2011 21:53:12 +0100 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Wed, 23 Feb 2011 07:29:33 -0300 perf lock: Document valid sort keys Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> LKML-Reference: <20110222205312.GA18474@joi.lan> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/Documentation/perf-lock.txt | 12 ++++++++++-- tools/perf/builtin-lock.c | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/Documentation/perf-lock.txt b/tools/perf/Documentation/perf-lock.txt index 921de25..4a26a2f 100644 --- a/tools/perf/Documentation/perf-lock.txt +++ b/tools/perf/Documentation/perf-lock.txt @@ -24,8 +24,8 @@ and statistics with this 'perf lock' command. 'perf lock report' reports statistical data. -OPTIONS -------- +COMMON OPTIONS +-------------- -i:: --input=<file>:: @@ -39,6 +39,14 @@ OPTIONS --dump-raw-trace:: Dump raw trace in ASCII. +REPORT OPTIONS +-------------- + +-k:: +--key=<value>:: + Sorting key. Possible values: acquired (default), contended, + wait_total, wait_max, wait_min. + SEE ALSO -------- linkperf:perf[1] diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c index e00d938..2e93f99 100644 --- a/tools/perf/builtin-lock.c +++ b/tools/perf/builtin-lock.c @@ -893,7 +893,7 @@ static const char * const report_usage[] = { static const struct option report_options[] = { OPT_STRING('k', "key", &sort_key, "acquired", - "key for sorting"), + "key for sorting (acquired / contended / wait_total / wait_max / wait_min)"), /* TODO: type */ OPT_END() }; ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-23 14:52 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-02-22 17:45 [PATCH] perf lock: show valid sort keys in usage Marcin Slusarz 2011-02-22 18:01 ` Arnaldo Carvalho de Melo 2011-02-22 20:53 ` Marcin Slusarz 2011-02-23 14:52 ` [tip:perf/core] perf lock: Document valid sort keys tip-bot for Marcin Slusarz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox