From: Marcelo Tosatti <mtosatti@redhat.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] kvm: allow RO page when atomic && !write_fault
Date: Tue, 22 Feb 2011 16:24:12 -0300 [thread overview]
Message-ID: <20110222192412.GA7645@amt.cnet> (raw)
In-Reply-To: <4D61E058.9080201@cn.fujitsu.com>
On Mon, Feb 21, 2011 at 11:47:36AM +0800, Lai Jiangshan wrote:
>
> Atomic-able hva_to_pfn() patches and allow-read-only-page patches
> are merged almost the same time. But hva_to_pfn() does not handle
> these two issues well together.
>
> When @atomic && !@write_fault && host-is-read-only-page-mapped
> the code will return fault_page, actually, it will be better
> if we return the pfn of the read-only-page.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Lai,
For pte prefetch, user of atomic hva_to_pfn, the write_fault parameter
is meaningless (since that information is only available for the pte
being faulted).
Returning fault page for a read-only page is useful so that pte prefetch
is aborted.
prev parent reply other threads:[~2011-02-22 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 3:47 [PATCH] kvm: allow RO page when atomic && !write_fault Lai Jiangshan
2011-02-21 9:47 ` Gleb Natapov
2011-02-22 8:24 ` Lai Jiangshan
2011-02-22 19:24 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222192412.GA7645@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox