From: Greg KH <gregkh@suse.de>
To: J Freyensee <james_p_freyensee@linux.intel.com>
Cc: Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org, suhail.ahmed@intel.com
Subject: Re: [PATCH 09/12] n_tracesink header file.
Date: Tue, 22 Feb 2011 12:26:25 -0800 [thread overview]
Message-ID: <20110222202625.GA24164@suse.de> (raw)
In-Reply-To: <1298406178.2315.7.camel@localhost>
On Tue, Feb 22, 2011 at 12:22:58PM -0800, J Freyensee wrote:
> On Thu, 2011-02-17 at 13:43 -0800, Greg KH wrote:
> > On Thu, Feb 17, 2011 at 12:10:47PM -0800, J Freyensee wrote:
> > > On Thu, 2011-02-17 at 11:54 -0800, Greg KH wrote:
> > > > On Thu, Feb 17, 2011 at 11:45:15AM -0800, J Freyensee wrote:
> > > > > On Thu, 2011-02-17 at 11:23 -0800, Greg KH wrote:
> > > > > > On Tue, Feb 08, 2011 at 11:34:54AM -0800, james_p_freyensee@linux.intel.com wrote:
> > > > > > > From: J Freyensee <james_p_freyensee@linux.intel.com>
> > > > > > >
> > > > > > > This header file allows the n_tracerouter to send it's information
> > > > > > > to the n_tracesink ldisc driver. It's part of the Intel-Atom
> > > > > > > PTI implementation solution.
> > > > > > >
> > > > > > > Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
> > > > > > > ---
> > > > > > > include/linux/n_tracesink.h | 32 ++++++++++++++++++++++++++++++++
> > > > > >
> > > > > > Why is this in include/linux/ ?
> > > > > >
> > > > >
> > > > > I thought this was the best place to stick this .h file. I'd be happy
> > > > > to change locations based off of your suggestion.
> > > >
> > > > Why do you need a .h file at all? Who is using it?
> > >
> > > The only current module that really uses it is n_tracerouter; however, I
> > > thought sticking this in a .h file made things slightly more modular and
> > > more re-usable, especially for future device driver writers that could
> > > want something like this.
> > >
> > > If you would like me to remove this though, I can, just let me know.
> >
> > Yes, please remove it.
> >
> Greg,
>
> If I remove this file I need to add the function header
> n_tracesink_datadrain() that is in this file to n_tracerouter.c.
>
> If I add that function header to n_tracerouter.c then checkpatch.pl
> complains that extern should be avoided in .c files.
>
> If I don't have this function header in n_tracerouter.c then it won't
> compile at all.
>
> Do you have an alternative suggestion on what I should do here? It
> appears the best solution is for me to keep this .h file considering the
> constraints.
Make it a "local" .h file, in the same directory as these two .c files,
no need to make it global for the whole of the kernel tree, right?
thanks,
greg k-h
next prev parent reply other threads:[~2011-02-22 20:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 19:34 Resend: Request for review and addition of PTI implementation into kernel james_p_freyensee
2011-02-08 19:34 ` [PATCH 01/12] export kernel call get_task_comm() james_p_freyensee
2011-02-08 19:34 ` [PATCH 02/12] Kernel documentation for the PTI feature james_p_freyensee
2011-02-08 19:34 ` [PATCH 03/12] Intel PTI implementaiton of 1149 james_p_freyensee
2011-02-08 19:34 ` [PATCH 04/12] PTI Kconfig change in misc james_p_freyensee
2011-02-08 19:34 ` [PATCH 05/12] PTI misc Makefile addition james_p_freyensee
2011-02-08 19:34 ` [PATCH 06/12] PTI header file james_p_freyensee
2011-02-08 19:34 ` [PATCH 07/12] n_tracerouter and n_tracesink additions james_p_freyensee
2011-02-08 19:34 ` [PATCH 08/12] n_tracesink ldisc addition james_p_freyensee
2011-02-08 19:34 ` [PATCH 09/12] n_tracesink header file james_p_freyensee
2011-02-08 19:34 ` [PATCH 10/12] n_tracerouter ldisc driver james_p_freyensee
2011-02-08 19:34 ` [PATCH 11/12] n_tracerouter and n_tracesink Kconfig james_p_freyensee
2011-02-08 19:34 ` [PATCH 12/12] n_tracerouter and n_tracesink Makefile addition james_p_freyensee
2011-02-08 21:03 ` [PATCH 11/12] n_tracerouter and n_tracesink Kconfig Randy Dunlap
2011-02-17 19:23 ` [PATCH 09/12] n_tracesink header file Greg KH
2011-02-17 19:45 ` J Freyensee
2011-02-17 19:54 ` Greg KH
2011-02-17 20:10 ` J Freyensee
2011-02-17 21:43 ` Greg KH
2011-02-22 20:22 ` J Freyensee
2011-02-22 20:26 ` Greg KH [this message]
2011-02-22 22:55 ` J Freyensee
2011-02-17 19:21 ` [PATCH 07/12] n_tracerouter and n_tracesink additions Greg KH
2011-02-17 19:43 ` J Freyensee
2011-02-17 19:54 ` Greg KH
2011-02-17 20:11 ` J Freyensee
2011-02-24 11:52 ` Alan Cox
2011-02-17 19:20 ` [PATCH 06/12] PTI header file Greg KH
2011-02-17 19:41 ` J Freyensee
2011-02-17 19:55 ` Greg KH
2011-02-17 20:13 ` J Freyensee
2011-02-17 19:20 ` [PATCH 04/12] PTI Kconfig change in misc Greg KH
2011-02-17 19:35 ` J Freyensee
2011-02-17 19:45 ` Greg KH
2011-02-08 20:55 ` [PATCH 02/12] Kernel documentation for the PTI feature Randy Dunlap
2011-02-08 19:38 ` [PATCH 01/12] export kernel call get_task_comm() Christoph Hellwig
2011-02-08 19:44 ` james_p_freyensee
2011-02-08 20:04 ` Christoph Hellwig
2011-02-08 20:35 ` james_p_freyensee
2011-02-08 20:28 ` Alan Cox
2011-02-08 20:28 ` Christoph Hellwig
2011-02-08 20:36 ` Alan Cox
2011-02-15 10:57 ` Christoph Hellwig
2011-02-22 18:38 ` J Freyensee
2011-02-22 18:41 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2011-02-09 0:17 [PATCH 02/12] Kernel documentation for the PTI feature james_p_freyensee
2011-02-09 0:17 ` [PATCH 03/12] Intel PTI implementaiton of 1149 james_p_freyensee
2011-02-09 0:17 ` [PATCH 04/12] PTI Kconfig change in misc james_p_freyensee
2011-02-09 0:17 ` [PATCH 05/12] PTI misc Makefile addition james_p_freyensee
2011-02-09 0:17 ` [PATCH 06/12] PTI header file james_p_freyensee
2011-02-09 0:17 ` [PATCH 07/12] n_tracerouter and n_tracesink additions james_p_freyensee
2011-02-09 0:17 ` [PATCH 08/12] n_tracesink ldisc addition james_p_freyensee
2011-02-09 0:17 ` [PATCH 09/12] n_tracesink header file james_p_freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222202625.GA24164@suse.de \
--to=gregkh@suse.de \
--cc=greg@kroah.com \
--cc=james_p_freyensee@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suhail.ahmed@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).