Re: [PATCH 2/2] debugfs: only allow root access to debugging interfaces

Steven Rostedt
2011-02-24T16:38:52Z

On Tue, Feb 22, 2011 at 05:58:47PM -0300, Henrique de Moraes Holschuh wrote:
>
> I do wish this went in. debugfs is a hazard, both security-wise and
> kernel-quality wise. Anything that has to end up enabled in a distro
> kernel really does not belong in debugfs. In fact, if you would object
> to a kernel taint if a feature is used, IMO it certainly don't belong on
> debugfs.
>

As I am one of the culprits of adding tool interfaces into debugfs, I'll
give my opinion too.

When I first started using debugfs, it was because it was so much easier
to add files to than /sys, and I remember /proc is something we do not
want to add more functionality to.

It was also because we had no idea how ftrace was going to be used and
what the final ABI was going to be. I was hoping that we can experiment
with the interface and after some time we could move it out of debugfs
with a stable ABI. But this, for various reasons, never materialized.

Currently things are still in a large flux, and I do not know how this
will play out. Although the changes in /debugfs/tracing has toned down a
lot, there's also the work going in on how to merge perf and ftrace.
This may start changes as well, and perhaps deprecate interfaces. I
don't know.

Having debugfs as the main interface was not the goal of all this, but
we seemed to have just gotten stuck with it.

-- Steve