Re: [PATCH 2/2] Staging: vme: fix potential infinite loop

[Manohar Vanga <manohar.vanga@cern.ch>]

On Tue, Feb 22, 2011 at 08:36:16PM +0100, Manohar Vanga wrote:
> Fix a bug in vme_register_bridge that resulted in an infinite loop if
> device_register failed.
> 
> Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>
> ---
>  drivers/staging/vme/vme.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
> index 88bf455..7eb4568 100644
> --- a/drivers/staging/vme/vme.c
> +++ b/drivers/staging/vme/vme.c
> @@ -1364,9 +1364,14 @@ int vme_register_bridge(struct vme_bridge *bridge)
>  	return retval;
>  
>  err_reg:
> +	/*
> +	 * Ignore the failed driver and unregister the rest
> +	 */
> +	i--

Ugh. Missing semicolon here. I'll resend the corrected patch.

Thanks,
Manohar Vanga