* [PATCH] ideapad: read brightness setting on brightness key notify
@ 2011-02-23 13:39 Ike Panhc
2011-02-23 13:47 ` Matthew Garrett
2011-03-11 17:31 ` Matthew Garrett
0 siblings, 2 replies; 6+ messages in thread
From: Ike Panhc @ 2011-02-23 13:39 UTC (permalink / raw)
To: platform-driver-x86, linux-kernel; +Cc: Matthew Garrett
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=25922
On ideapad Y530, the brightness key notify will be blocked if the last notify
is not responsed by getting the brightness value. Read value when we get the
notify shall fix the problem and will not have any difference on other ideapads.
Signed-off-by: Ike Panhc <ike.pan@canonical.com>
---
drivers/platform/x86/ideapad-laptop.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 114d952..21b1018 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -459,6 +459,8 @@ static void ideapad_acpi_notify(struct acpi_device *adevice, u32 event)
if (test_bit(vpc_bit, &vpc1)) {
if (vpc_bit == 9)
ideapad_sync_rfk_state(adevice);
+ else if (vpc_bit == 4)
+ read_ec_data(handle, 0x12, &vpc2);
else
ideapad_input_report(priv, vpc_bit);
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ideapad: read brightness setting on brightness key notify
2011-02-23 13:39 [PATCH] ideapad: read brightness setting on brightness key notify Ike Panhc
@ 2011-02-23 13:47 ` Matthew Garrett
2011-02-23 14:07 ` Ike Panhc
2011-03-11 17:31 ` Matthew Garrett
1 sibling, 1 reply; 6+ messages in thread
From: Matthew Garrett @ 2011-02-23 13:47 UTC (permalink / raw)
To: Ike Panhc; +Cc: platform-driver-x86, linux-kernel
On Wed, Feb 23, 2011 at 09:39:59PM +0800, Ike Panhc wrote:
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=25922
>
> On ideapad Y530, the brightness key notify will be blocked if the last notify
> is not responsed by getting the brightness value. Read value when we get the
> notify shall fix the problem and will not have any difference on other ideapads.
Which kernel versions does this hit?
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ideapad: read brightness setting on brightness key notify
2011-02-23 13:47 ` Matthew Garrett
@ 2011-02-23 14:07 ` Ike Panhc
2011-02-23 14:22 ` Matthew Garrett
0 siblings, 1 reply; 6+ messages in thread
From: Ike Panhc @ 2011-02-23 14:07 UTC (permalink / raw)
To: Matthew Garrett; +Cc: platform-driver-x86, linux-kernel
On 02/23/2011 09:47 PM, Matthew Garrett wrote:
>
> Which kernel versions does this hit?
>
This patch is made against current checkout of Linus's tree.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ideapad: read brightness setting on brightness key notify
2011-02-23 14:07 ` Ike Panhc
@ 2011-02-23 14:22 ` Matthew Garrett
2011-02-23 14:43 ` Ike Panhc
0 siblings, 1 reply; 6+ messages in thread
From: Matthew Garrett @ 2011-02-23 14:22 UTC (permalink / raw)
To: Ike Panhc; +Cc: platform-driver-x86, linux-kernel
On Wed, Feb 23, 2011 at 10:07:12PM +0800, Ike Panhc wrote:
> On 02/23/2011 09:47 PM, Matthew Garrett wrote:
> >
> > Which kernel versions does this hit?
> >
>
> This patch is made against current checkout of Linus's tree.
The bug, not the patch :)
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ideapad: read brightness setting on brightness key notify
2011-02-23 14:22 ` Matthew Garrett
@ 2011-02-23 14:43 ` Ike Panhc
0 siblings, 0 replies; 6+ messages in thread
From: Ike Panhc @ 2011-02-23 14:43 UTC (permalink / raw)
To: Matthew Garrett; +Cc: platform-driver-x86, linux-kernel
On 02/23/2011 10:22 PM, Matthew Garrett wrote:
> On Wed, Feb 23, 2011 at 10:07:12PM +0800, Ike Panhc wrote:
>> On 02/23/2011 09:47 PM, Matthew Garrett wrote:
>>>
>>> Which kernel versions does this hit?
>>>
>>
>> This patch is made against current checkout of Linus's tree.
>
> The bug, not the patch :)
>
This bug hits .37 and later. But patch is not suitable for .37.y
I will make another patch for stable kernel.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ideapad: read brightness setting on brightness key notify
2011-02-23 13:39 [PATCH] ideapad: read brightness setting on brightness key notify Ike Panhc
2011-02-23 13:47 ` Matthew Garrett
@ 2011-03-11 17:31 ` Matthew Garrett
1 sibling, 0 replies; 6+ messages in thread
From: Matthew Garrett @ 2011-03-11 17:31 UTC (permalink / raw)
To: Ike Panhc; +Cc: platform-driver-x86, linux-kernel
Applied, thanks.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-11 17:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-23 13:39 [PATCH] ideapad: read brightness setting on brightness key notify Ike Panhc
2011-02-23 13:47 ` Matthew Garrett
2011-02-23 14:07 ` Ike Panhc
2011-02-23 14:22 ` Matthew Garrett
2011-02-23 14:43 ` Ike Panhc
2011-03-11 17:31 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox