From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@slimlogic.co.uk>,
Yong Shen <yong.shen@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Alberto Panizzo <maramaopercheseimorto@gmail.com>
Subject: Re: [PATCH] regulator, mc13xxx: Remove pointless test for unsigned less than zero
Date: Thu, 24 Feb 2011 09:37:17 +0000 [thread overview]
Message-ID: <20110224093717.GG8226@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1102232341030.28678@swampdragon.chaosbits.net>
On Wed, Feb 23, 2011 at 11:45:55PM +0100, Jesper Juhl wrote:
> The variable 'val' is a 'unsigned int', so it can never be less than zero.
> This fact makes the "val < 0" part of the test done in BUG_ON() in
> mc13xxx_regulator_get_voltage() rather pointles since it can never have
> any effect.
> This patch removes the pointless test.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2011-02-24 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 22:45 [PATCH] regulator, mc13xxx: Remove pointless test for unsigned less than zero Jesper Juhl
2011-02-24 9:13 ` Alberto Panizzo
2011-02-24 9:39 ` Mark Brown
2011-02-24 9:37 ` Mark Brown [this message]
2011-02-25 8:55 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224093717.GG8226@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=maramaopercheseimorto@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=yong.shen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox