From: Arnd Bergmann <arnd@arndb.de>
To: devicetree-discuss@lists.ozlabs.org
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <robherring2@gmail.com>,
linux-kernel@vger.kernel.org,
Christian Krafft <parabelboi@bopserverein.de>
Subject: Re: [RFC PATCH] ipmi: convert OF driver to platform driver
Date: Thu, 24 Feb 2011 15:34:50 +0100 [thread overview]
Message-ID: <201102241534.50886.arnd@arndb.de> (raw)
In-Reply-To: <20110224031528.GB12139@angua.secretlab.ca>
On Thursday 24 February 2011, Grant Likely wrote:
> On Wed, Feb 23, 2011 at 03:37:59PM -0600, Rob Herring wrote:
> > From: Rob Herring <rob.herring@calxeda.com>
> >
> > of_bus is deprecated in favor of the plain platform bus. This patch
> > merges the ipmi OF driver with the existing platform driver.
> >
> > CONFIG_PPC_OF occurrances are removed or replaced with CONFIG_OF.
> >
> > Compile tested with and without CONFIG_OF. Tested OF probe and
> > default probe cases.
> >
> > Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>
> Wow. That driver does some weird things with the driver model that
> really should be cleaned up. That said, this change looks correct.
> I'll add it to my tree and see how it goes.
Please keep me in the look when you want to do further into cleaning
this up. The OF code was initially done for the QS21 running SLOF, and
predates the flattened device tree specs.
I don't know if Christian still remembers the code, but it might
be worthwhile having him on Cc as well.
Arnd
next prev parent reply other threads:[~2011-02-25 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 21:37 [RFC PATCH] ipmi: convert OF driver to platform driver Rob Herring
2011-02-24 3:15 ` Grant Likely
2011-02-24 14:34 ` Arnd Bergmann [this message]
2011-02-28 8:04 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102241534.50886.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=parabelboi@bopserverein.de \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox