From: David Sterba <dsterba@suse.cz>
To: Borislav Petkov <bp@amd64.org>
Cc: David Sterba <dsterba@suse.cz>,
"mchehab@redhat.com" <mchehab@redhat.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][RESEND] i7core_edac: fix misuse of logical operation in place of bitop
Date: Thu, 24 Feb 2011 18:04:55 +0100 [thread overview]
Message-ID: <20110224170455.GC17619@ds.suse.cz> (raw)
In-Reply-To: <20110224140541.GB11239@aftab>
On Thu, Feb 24, 2011 at 03:05:41PM +0100, Borislav Petkov wrote:
> Yeah, this looks wrong. Is this tested?
Compile tested, I don't have the hw at hand.
> Is it something you hit when running the driver or you've caught it
> with some tool/by code staring?
It was found by clang compiler.
> If it is a real problem for you, I could make an exception and send it
> to Linus next week if Mauro doesn't do it before that.
Not a problem for me, I just don't want let the patch fall on the floor.
Thanks,
dave
prev parent reply other threads:[~2011-02-24 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 14:41 [PATCH][RESEND] i7core_edac: fix misuse of logical operation in place of bitop David Sterba
2011-02-24 14:05 ` Borislav Petkov
2011-02-24 14:09 ` Mauro Carvalho Chehab
2011-02-24 17:04 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224170455.GC17619@ds.suse.cz \
--to=dsterba@suse.cz \
--cc=bp@amd64.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox