Re: [PATCH] expose kvmclock upper msr set.

Avi Kivity
2011-02-28T13:30:12Z

On 02/28/2011 03:24 PM, Glauber Costa wrote:
> On Sun, 2011-02-27 at 14:16 +0200, Avi Kivity wrote:
> > On 02/23/2011 07:44 PM, Glauber Costa wrote:
> > > We've been supporting kvmclock MSRs in the 0x4b564d00-0x4b564dff range
> > > for a while now, but we're not exposing it yet, meaning nobody is using it.
> > > This simple patch takes care of that.
> >
> > We're exposing them via KVM_GET_SUPPORTED_CPUID, leaf KVM_CPUID_FEATURES.
> >
> Our userspace does not really use it, and rely on the capability list.
> Historically, we've been relying on the capabilities mechanism to
> indicate what exists and what does not.

Yes. I believe this bit marked the change point.

Anyway, it's exposed, and it's a lot better for userspace to make use of
KVM_GET_SUPPORTED_CPUID since it will work on more kernels.

--
error compiling committee.c: too many arguments to function