From: Greg KH <gregkh@suse.de>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
virtualization@lists.osdl.org,
Haiyang Zhang <haiyangz@microsoft.com>,
Hank Janssen <hjanssen@microsoft.com>
Subject: Re: [PATCH ] Staging: hv: Hyper-V driver cleanup
Date: Thu, 24 Feb 2011 15:45:41 -0800 [thread overview]
Message-ID: <20110224234541.GA23711@suse.de> (raw)
In-Reply-To: <1298589658-23126-1-git-send-email-kys@microsoft.com>
On Thu, Feb 24, 2011 at 03:20:58PM -0800, K. Y. Srinivasan wrote:
> This patch cleans up (a lot of the) naming issues that
> various reviewers have noted. It also gets rid of
> some unnecessary layering in the code.
Whenever you have a patch description that says "It also..." you know
you need to break this up into smaller, logical pieces.
As it is, I can not take this patch.
Please break it up into logical patches, each doing only one thing, so
we can properly review it.
> At the lowest
> level, we have one abstraction for representing
> a hyperv device (struct hyperv_device) and one
> abstraction for representing a hyperv driver
> (struct hyperv_driver). This collapses an unnecessary
> layering that existed in the code for historical reasons.
> While the patch is large, it was generated by a very
> mechanical process (global search and replace). The code
> compiles cleanly and I have tested this code on a 2.6.38
> kernel.
There is no 2.6.38 kernel yet, so I find this very hard to believe :)
thanks,
greg k-h
next prev parent reply other threads:[~2011-02-24 23:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 23:20 [PATCH ] Staging: hv: Hyper-V driver cleanup K. Y. Srinivasan
2011-02-24 23:45 ` Greg KH [this message]
2011-02-25 0:24 ` KY Srinivasan
2011-02-25 0:31 ` Greg KH
2011-02-25 1:07 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224234541.GA23711@suse.de \
--to=gregkh@suse.de \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox