From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756643Ab1BXXqb (ORCPT ); Thu, 24 Feb 2011 18:46:31 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57851 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756434Ab1BXXq2 (ORCPT ); Thu, 24 Feb 2011 18:46:28 -0500 Date: Thu, 24 Feb 2011 15:45:41 -0800 From: Greg KH To: "K. Y. Srinivasan" Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, virtualization@lists.osdl.org, Haiyang Zhang , Hank Janssen Subject: Re: [PATCH ] Staging: hv: Hyper-V driver cleanup Message-ID: <20110224234541.GA23711@suse.de> References: <1298589658-23126-1-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1298589658-23126-1-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 24, 2011 at 03:20:58PM -0800, K. Y. Srinivasan wrote: > This patch cleans up (a lot of the) naming issues that > various reviewers have noted. It also gets rid of > some unnecessary layering in the code. Whenever you have a patch description that says "It also..." you know you need to break this up into smaller, logical pieces. As it is, I can not take this patch. Please break it up into logical patches, each doing only one thing, so we can properly review it. > At the lowest > level, we have one abstraction for representing > a hyperv device (struct hyperv_device) and one > abstraction for representing a hyperv driver > (struct hyperv_driver). This collapses an unnecessary > layering that existed in the code for historical reasons. > While the patch is large, it was generated by a very > mechanical process (global search and replace). The code > compiles cleanly and I have tested this code on a 2.6.38 > kernel. There is no 2.6.38 kernel yet, so I find this very hard to believe :) thanks, greg k-h