From: Greg KH <gregkh@suse.de>
To: Belisko Marek <marek.belisko@gmail.com>
Cc: alan@linux.intel.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gma500: Fix compilation error.
Date: Thu, 24 Feb 2011 16:43:42 -0800 [thread overview]
Message-ID: <20110225004342.GA27647@suse.de> (raw)
In-Reply-To: <AANLkTimTePRqSZ5=oJPrEM1cdu0zNPmWGfm_AbN3OdiJ@mail.gmail.com>
On Thu, Feb 24, 2011 at 08:58:52PM +0100, Belisko Marek wrote:
> Hi Greg,
>
> On Thu, Feb 24, 2011 at 6:12 PM, Greg KH <gregkh@suse.de> wrote:
> > On Thu, Feb 24, 2011 at 10:33:18AM +0100, Marek Belisko wrote:
> >> This patch will fix following compilation error:
> >> drivers/staging/gma500/psb_drv.c:1635: error: unknown field ‘pci_driver’ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1636: error: unknown field ‘name’ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1636: warning: initialization from incompatible pointer type
> >> drivers/staging/gma500/psb_drv.c:1637: error: unknown field ‘id_table’ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1637: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1637: warning: (near initialization for ‘driver.kdriver’)
> >> drivers/staging/gma500/psb_drv.c:1638: error: unknown field ‘resume’ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1638: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1638: warning: (near initialization for ‘driver.kdriver’)
> >> drivers/staging/gma500/psb_drv.c:1639: error: unknown field ‘suspend’ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1639: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1639: warning: (near initialization for ‘driver.kdriver’)
> >> drivers/staging/gma500/psb_drv.c:1640: error: unknown field ‘probe’ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1640: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1640: warning: (near initialization for ‘driver.kdriver’)
> >> drivers/staging/gma500/psb_drv.c:1641: error: unknown field ‘remove’ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1641: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1641: warning: (near initialization for ‘driver.kdriver’)
> >> drivers/staging/gma500/psb_drv.c:1643: error: unknown field ‘driver’ specified in initializer
> >> drivers/staging/gma500/psb_drv.c:1643: warning: excess elements in union initializer
> >> drivers/staging/gma500/psb_drv.c:1643: warning: (near initialization for ‘driver.kdriver’)
> >> drivers/staging/gma500/psb_drv.c: In function ‘psb_init’:
> >> drivers/staging/gma500/psb_drv.c:1664: error: implicit declaration of function ‘drm_init’
> >> drivers/staging/gma500/psb_drv.c: In function ‘psb_exit’:
> >> drivers/staging/gma500/psb_drv.c:1669: error: implicit declaration of function ‘drm_exit’
> >>
> >> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> >
> > Odd, how come I'm not hitting these in the staging-next tree? Is it
> > because an api changed in the DRM layer in the linux-next tree?
> Yes DRM api was changed:
> commit 8410ea3b95d105a5be5db501656f44bbb91197c1
> Author: Dave Airlie <airlied@gmail.com>
> Date: Wed Dec 15 03:16:38 2010 +1000
>
> drm: rework PCI/platform driver interface.
>
> Introduce union kdriver which encapsulate pci_driver struct.
> That's cause of error in gma500.
Ok, this is going to get messy then, this patch should be held by
Stephen in linux-next until we merge stuff with Linus, and then I'll be
able to apply it to my tree. So I'll just save it in my queue until
that time happens, thanks.
greg k-h
prev parent reply other threads:[~2011-02-25 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 9:33 [PATCH] staging: gma500: Fix compilation error Marek Belisko
2011-02-24 12:51 ` Alan Cox
2011-02-24 17:12 ` Greg KH
2011-02-24 19:58 ` Belisko Marek
2011-02-25 0:43 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110225004342.GA27647@suse.de \
--to=gregkh@suse.de \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox