From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Tardy, Pierre" <pierre.tardy@intel.com>
Cc: Chris Ball <cjb@laptop.org>, Pierre Tardy <tardyp@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"linux-pm@lists.linux-foundation.org"
<linux-pm@lists.linux-foundation.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Gao, Yunpeng" <yunpeng.gao@intel.com>
Subject: Re: [PATCH v2 2/3] sdhci-pci : Enable runtime PM support
Date: Fri, 25 Feb 2011 14:54:40 +0000 [thread overview]
Message-ID: <20110225145440.GA31620@srcf.ucam.org> (raw)
In-Reply-To: <8250E4885F9967469CAC3FB5CBA2CE69935212DEA0@irsmsx501.ger.corp.intel.com>
On Fri, Feb 25, 2011 at 07:33:12AM +0000, Tardy, Pierre wrote:
> My understanding is the pci driver is not supposed to do any set_power_state/pci_save_state/wake_enable.
> Everything is supposed to be generically handle by pci frameworks's runtime_pm impl.
> Need confirmation from Rafael.
The core can only enable PME generation, it can't configure what
generates PMEs. There's a register in sdhci that needs to be programmed
to enable wakeups on card insert/removal/interrupt. If you don't then
you won't get a PME no matter what the core does.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-02-25 14:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 18:02 [PATCH v2 0/3] sdhci runtime_pm implementation using mmc clock gating fw Pierre Tardy
2011-02-06 18:02 ` [PATCH v2 1/3] mmc: put the led blinking code after clock ungating Pierre Tardy
2011-02-06 18:02 ` [PATCH v2 2/3] sdhci-pci : Enable runtime PM support Pierre Tardy
2011-02-06 21:15 ` Chris Ball
2011-02-10 4:37 ` Chris Ball
2011-02-13 10:42 ` Pierre Tardy
2011-02-21 20:45 ` Chris Ball
2011-02-25 7:33 ` Tardy, Pierre
2011-02-25 14:54 ` Matthew Garrett [this message]
2011-02-25 18:28 ` R. J. Wysocki
2011-02-06 18:02 ` [PATCH v2 3/3] sdhci:v2:use ios->clock to know when sdhci is idle Pierre Tardy
2011-02-06 18:54 ` [PATCH v2 0/3] sdhci runtime_pm implementation using mmc clock gating fw Linus Walleij
2011-02-06 20:35 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110225145440.GA31620@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pierre.tardy@intel.com \
--cc=rjw@sisk.pl \
--cc=tardyp@gmail.com \
--cc=yunpeng.gao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox