From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Dominik Klein <dk@in-telegence.net>,
linux kernel mailing list <linux-kernel@vger.kernel.org>,
libvir-list@redhat.com
Subject: Re: Is it a workqueue related issue in 2.6.37 (Was: Re: [libvirt] blkio cgroup [solved])
Date: Fri, 25 Feb 2011 11:19:05 -0500 [thread overview]
Message-ID: <20110225161905.GG2994@redhat.com> (raw)
In-Reply-To: <20110225160903.GR24828@htj.dyndns.org>
On Fri, Feb 25, 2011 at 05:09:03PM +0100, Tejun Heo wrote:
> Hello,
>
> On Fri, Feb 25, 2011 at 11:03:53AM -0500, Vivek Goyal wrote:
> > +int kthrotld_schedule_delayed_work(struct throtl_data *td,
> > + struct delayed_work *dwork, unsigned long delay)
> > +{
> > + return queue_delayed_work(kthrotld_workqueue, dwork, delay);
> > +}
> > +
>
> I don't think wrapping is necessary. Defining and using a workqueue
> directly should be enough.
>
> > @@ -1113,6 +1120,11 @@ void blk_throtl_exit(struct request_queu
> >
> > static int __init throtl_init(void)
> > {
> > + kthrotld_workqueue = alloc_workqueue("kthrotld",
> > + WQ_MEM_RECLAIM | WQ_HIGHPRI, 0);
>
> And I don't think kthrotld needs to be HIGHPRI.
Ok, regenerating the patch with above change. Anyway I had to as I
generated this patch on top of some of my local commits which are
not in Linus tree yet.
Thanks
Vivek
next prev parent reply other threads:[~2011-02-25 16:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110218163137.GF26654@redhat.com>
[not found] ` <4D621B9B.3070205@in-telegence.net>
[not found] ` <4D622002.2040604@in-telegence.net>
[not found] ` <4D6222A8.6090303@in-telegence.net>
[not found] ` <20110221184442.GM6428@redhat.com>
[not found] ` <4D63BA3B.7070809@in-telegence.net>
[not found] ` <20110222152426.GD28269@redhat.com>
[not found] ` <20110222190953.GF28269@redhat.com>
[not found] ` <4D650D7E.4050908@in-telegence.net>
[not found] ` <4D662248.6040405@in-telegence.net>
2011-02-24 14:23 ` Is it a workqueue related issue in 2.6.37 (Was: Re: [libvirt] blkio cgroup [solved]) Vivek Goyal
2011-02-24 14:31 ` Tejun Heo
2011-02-24 14:58 ` Dominik Klein
2011-02-24 15:17 ` Tejun Heo
2011-02-25 7:24 ` Dominik Klein
2011-02-25 11:29 ` Tejun Heo
2011-02-25 11:46 ` Dominik Klein
2011-02-25 13:18 ` Tejun Heo
2011-02-25 14:41 ` Dominik Klein
2011-02-25 14:55 ` Tejun Heo
2011-02-25 14:57 ` Vivek Goyal
2011-02-25 15:03 ` Tejun Heo
2011-02-25 15:11 ` Vivek Goyal
2011-02-25 15:15 ` Vivek Goyal
2011-02-25 16:03 ` Vivek Goyal
2011-02-25 16:09 ` Tejun Heo
2011-02-25 16:19 ` Vivek Goyal [this message]
2011-02-25 16:30 ` Vivek Goyal
2011-02-25 16:56 ` Dominik Klein
2011-02-25 19:53 ` Steven Rostedt
2011-02-25 20:18 ` Vivek Goyal
2011-02-26 2:47 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110225161905.GG2994@redhat.com \
--to=vgoyal@redhat.com \
--cc=dk@in-telegence.net \
--cc=libvir-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox