[PATCH 10/10] n_tracerouter and n_tracesink compile configurations.

[PATCH 10/10] n_tracerouter and n_tracesink compile configurations.

[james_p_freyensee]

From: J Freyensee <james_p_freyensee@linux.intel.com>

This patch allows n_tracerouter and n_tracesink to be compiled and
configured in the Linux kernel.

Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
---
 drivers/char/Kconfig |   32 ++++++++++++++++++++++++++++++++
 drivers/tty/Makefile |    2 ++
 2 files changed, 34 insertions(+), 0 deletions(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 43d3395..02b9be2 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -289,6 +289,38 @@ config N_GSM
 	  This line discipline provides support for the GSM MUX protocol and
 	  presents the mux as a set of 61 individual tty devices.
 
+config TRACE_ROUTER
+        tristate "Trace data router for MIPI P1149.7 cJTAG standard"
+                depends on TRACE_SINK
+                default Y
+        ---help---
+          The trace router uses the Linux tty line discipline framework to
+          route trace data coming from a tty port (say UART for example) to
+           the trace sink line discipline driver and to another tty port(say USB).
+           This is part of a solution for the MIPI P1149.7, compact JTAG,
+           standard, which is for debugging mobile devices. The PTI driver in
+           drivers/misc/pti.c defines the majority of this MIPI solution.
+
+          You should select this driver if the target kernel is meant for
+          a mobile device containing a modem.  Then you will need to select
+          "Trace data sink for MIPI P1149.7 cJTAG standard" line discipline
+          driver.
+
+config TRACE_SINK
+        tristate "Trace data sink for MIPI P1149.7 cJTAG standard"
+                default Y
+        ---help---
+          The trace sink uses the Linux line discipline framework to receive
+          trace data coming from the trace router line discipline driver
+          to a user-defined tty port target, like USB.
+          This is to provide a way to extract modem trace data on
+          devices that do not have a PTI HW module, or just need modem
+          trace data to come out of a different HW output port.
+          This is part of a solution for the P1149.7, compact JTAG, standard.
+
+          If you select this option, you need to select
+          "Trace data router for MIPI P1149.7 cJTAG standard".
+
 config RISCOM8
 	tristate "SDL RISCom/8 card support"
 	depends on SERIAL_NONSTANDARD
diff --git a/drivers/tty/Makefile b/drivers/tty/Makefile
index c43ef48..8c56ffd 100644
--- a/drivers/tty/Makefile
+++ b/drivers/tty/Makefile
@@ -7,5 +7,7 @@ obj-$(CONFIG_MAGIC_SYSRQ)	+= sysrq.o
 obj-$(CONFIG_N_HDLC)		+= n_hdlc.o
 obj-$(CONFIG_N_GSM)		+= n_gsm.o
 obj-$(CONFIG_R3964)		+= n_r3964.o
+obj-$(CONFIG_TRACE_ROUTER)      += n_tracerouter.o
+obj-$(CONFIG_TRACE_SINK)        += n_tracesink.o
 
 obj-y				+= vt/
-- 
1.7.2.3

Re: [PATCH 10/10] n_tracerouter and n_tracesink compile configurations.

[Greg KH]

On Thu, Feb 24, 2011 at 10:07:04AM -0800, james_p_freyensee@linux.intel.com wrote:
> From: J Freyensee <james_p_freyensee@linux.intel.com>
> 
> This patch allows n_tracerouter and n_tracesink to be compiled and
> configured in the Linux kernel.
> 
> Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
> ---
>  drivers/char/Kconfig |   32 ++++++++++++++++++++++++++++++++

Why drivers/char/Kconfig?  This should be in drivers/tty/Kconfig, right?

Yes, this is a recent change, see the linux-next tree for the addition
of this file :)

thanks,

greg k-h

Re: [PATCH 10/10] n_tracerouter and n_tracesink compile configurations.

[Greg KH]

On Thu, Feb 24, 2011 at 10:07:04AM -0800, james_p_freyensee@linux.intel.com wrote:
> --- a/drivers/tty/Makefile
> +++ b/drivers/tty/Makefile
> @@ -7,5 +7,7 @@ obj-$(CONFIG_MAGIC_SYSRQ)	+= sysrq.o
>  obj-$(CONFIG_N_HDLC)		+= n_hdlc.o
>  obj-$(CONFIG_N_GSM)		+= n_gsm.o
>  obj-$(CONFIG_R3964)		+= n_r3964.o
> +obj-$(CONFIG_TRACE_ROUTER)      += n_tracerouter.o
> +obj-$(CONFIG_TRACE_SINK)        += n_tracesink.o

Please follow the standards of this file and use tabs :(

Re: [PATCH 10/10] n_tracerouter and n_tracesink compile configurations.

[J Freyensee]

On Fri, 2011-02-25 at 10:00 -0800, Greg KH wrote:
> On Thu, Feb 24, 2011 at 10:07:04AM -0800, james_p_freyensee@linux.intel.com wrote:
> > From: J Freyensee <james_p_freyensee@linux.intel.com>
> > 
> > This patch allows n_tracerouter and n_tracesink to be compiled and
> > configured in the Linux kernel.
> > 
> > Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
> > ---
> >  drivers/char/Kconfig |   32 ++++++++++++++++++++++++++++++++
> 
> Why drivers/char/Kconfig?  This should be in drivers/tty/Kconfig, right?
> 
> Yes, this is a recent change, see the linux-next tree for the addition
> of this file :)
> 

That is what I was going to ask because I did base this patch off of the
2.6.37 stable tree and did not see a drivers/tty/Kconfig :-O.  I figured
the stable branch was the better choice since you own it and I need to
go through you for my work.

So I should pull from linux-next I guess to fix the changes mentioned
this round?:

-Thomas's comments on Patch 9.
-These issues in this patch

?

Thanks,
jay

> thanks,
> 
> greg k-h

Re: [PATCH 10/10] n_tracerouter and n_tracesink compile configurations.

[Greg KH]

On Fri, Feb 25, 2011 at 10:39:12AM -0800, J Freyensee wrote:
> On Fri, 2011-02-25 at 10:00 -0800, Greg KH wrote:
> > On Thu, Feb 24, 2011 at 10:07:04AM -0800, james_p_freyensee@linux.intel.com wrote:
> > > From: J Freyensee <james_p_freyensee@linux.intel.com>
> > > 
> > > This patch allows n_tracerouter and n_tracesink to be compiled and
> > > configured in the Linux kernel.
> > > 
> > > Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
> > > ---
> > >  drivers/char/Kconfig |   32 ++++++++++++++++++++++++++++++++
> > 
> > Why drivers/char/Kconfig?  This should be in drivers/tty/Kconfig, right?
> > 
> > Yes, this is a recent change, see the linux-next tree for the addition
> > of this file :)
> > 
> 
> That is what I was going to ask because I did base this patch off of the
> 2.6.37 stable tree and did not see a drivers/tty/Kconfig :-O.  I figured
> the stable branch was the better choice since you own it and I need to
> go through you for my work.

You should always submit against linux-next as that's pretty close to
the tree that we would be able to apply your patches to.  We can't go
back in time and add them to 2.6.37 :)

> So I should pull from linux-next I guess to fix the changes mentioned
> this round?:
> 
> -Thomas's comments on Patch 9.
> -These issues in this patch

Yes.

thanks,

greg k-h