Re: [PATCH 10/10] n_tracerouter and n_tracesink compile configurations.

[Greg KH <greg@kroah.com>]

On Fri, Feb 25, 2011 at 10:39:12AM -0800, J Freyensee wrote:
> On Fri, 2011-02-25 at 10:00 -0800, Greg KH wrote:
> > On Thu, Feb 24, 2011 at 10:07:04AM -0800, james_p_freyensee@linux.intel.com wrote:
> > > From: J Freyensee <james_p_freyensee@linux.intel.com>
> > > 
> > > This patch allows n_tracerouter and n_tracesink to be compiled and
> > > configured in the Linux kernel.
> > > 
> > > Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
> > > ---
> > >  drivers/char/Kconfig |   32 ++++++++++++++++++++++++++++++++
> > 
> > Why drivers/char/Kconfig?  This should be in drivers/tty/Kconfig, right?
> > 
> > Yes, this is a recent change, see the linux-next tree for the addition
> > of this file :)
> > 
> 
> That is what I was going to ask because I did base this patch off of the
> 2.6.37 stable tree and did not see a drivers/tty/Kconfig :-O.  I figured
> the stable branch was the better choice since you own it and I need to
> go through you for my work.

You should always submit against linux-next as that's pretty close to
the tree that we would be able to apply your patches to.  We can't go
back in time and add them to 2.6.37 :)

> So I should pull from linux-next I guess to fix the changes mentioned
> this round?:
> 
> -Thomas's comments on Patch 9.
> -These issues in this patch

Yes.

thanks,

greg k-h