public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee@canonical.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Arjan van de Ven <arjan@infradead.org>,
	Venkatesh Pallipadi <venki@google.com>,
	Len Brown <lenb@kernel.org>
Subject: Re: Performance/resume issues on Toshiba NB305
Date: Fri, 25 Feb 2011 16:29:00 -0600	[thread overview]
Message-ID: <20110225222900.GD24686@thinkpad-t410> (raw)
In-Reply-To: <alpine.LFD.2.00.1102252231200.2701@localhost6.localdomain6>

On Fri, Feb 25, 2011 at 10:47:16PM +0100, Thomas Gleixner wrote:
> Let's wait for the intel and acpi folks. It would be interesting what
> the new intel toy says to your BIOS.
> 
>     http://biosbits.org/

Not much because it doesn't know about my processor. About all I could
get out of it is that my MSRs are inconsistent, SMI latency is bad, and
the round-trip latency via MWAIT test gives elapsed time = 285ms with
229 iterations/ms.

> > Then there must be a bug. When I cleared CLOCK_EVT_FEAT_ONESHOT for the
> > HPET without this change the HPET got put into oneshot mode. The local
> > tick device is checked before switching to nohz, but not the broadcast
> > device. This change was just a quick hack to get around that and test my
> > theory.
> 
> Indeed. The patch below should cure that.

It works. I was wondering whether or not I should put the broadcast
device in periodic mode with the local ones in nohz; I guess your patch
answers my question.

> 
> Thanks,
> 
> 	tglx
> 
> ----------->
> Subject: clockevents-fix-broadcast.patch
> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Fri, 25 Feb 2011 22:34:23 +0100
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Tested-by: Seth Forshee <seth.forshee@canonical.com>


  reply	other threads:[~2011-02-25 22:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-25 16:42 Performance/resume issues on Toshiba NB305 Seth Forshee
2011-02-25 20:17 ` Steven Rostedt
2011-02-25 20:27   ` Seth Forshee
2011-02-25 22:11     ` Thomas Gleixner
2011-02-25 22:33       ` Seth Forshee
2011-02-25 20:37 ` Thomas Gleixner
2011-02-25 21:21   ` Seth Forshee
2011-02-25 21:47     ` Thomas Gleixner
2011-02-25 22:29       ` Seth Forshee [this message]
2011-02-25 22:40         ` Thomas Gleixner
2011-02-26  5:58           ` Burt Triplett
2011-02-26 15:00             ` Seth Forshee
2011-02-27 20:17               ` Burt Triplett
2011-02-28 15:10                 ` Seth Forshee
2011-03-05  5:55                   ` Burt Triplett
2011-02-26  8:49       ` [tip:timers/urgent] clockevents: Prevent oneshot mode when broadcast device is periodic tip-bot for Thomas Gleixner
2011-03-01 20:04       ` Performance/resume issues on Toshiba NB305 Seth Forshee
2011-03-01 20:22         ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110225222900.GD24686@thinkpad-t410 \
    --to=seth.forshee@canonical.com \
    --cc=arjan@infradead.org \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=venki@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox