From: Dan Carpenter <error27@gmail.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org
Subject: Re: [PATCH 3/6] Staging: hv: Cleanup hyperv_device variable names
Date: Sat, 26 Feb 2011 06:33:23 +0300 [thread overview]
Message-ID: <20110226033323.GD18043@bicker> (raw)
In-Reply-To: <1298685992-30864-1-git-send-email-kys@microsoft.com>
On Fri, Feb 25, 2011 at 06:06:32PM -0800, K. Y. Srinivasan wrote:
> Cleanup the names of variables that refer to the
> hyperv_device abstraction.
>
I have a script I run on rename patches. For this patch the
command would be:
rename_rev.pl -nc -e 's/device_ctx/device_obj/g' -e 's/\bdev_ctx/dev/g'
It show one variable was missed in storvsc_probe().
> memset(host_device_ctx, 0, sizeof(struct host_device_context));
>
> host_device_ctx->port = host->host_no;
> - host_device_ctx->device_ctx = device_obj;
> + host_device_ctx->device_obj = device_obj;
>
> host_device_ctx->request_pool =
> kmem_cache_create(dev_name(&device_obj->device),
> @@ -271,7 +271,7 @@ static int storvsc_probe(struct device *device)
> return -1;
> }
>
> - /* host_device_ctx->port = device_info.PortNumber; */
> + /* host_hyperv_dev->port = device_info.PortNumber; */
> host_device_ctx->path = device_info.path_id;
> host_device_ctx->target = device_info.target_id;
>
All the other host_device_ctx variables were renamed to host_device_obj.
regards,
dan carpenter
next prev parent reply other threads:[~2011-02-26 3:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 2:06 [PATCH 3/6] Staging: hv: Cleanup hyperv_device variable names K. Y. Srinivasan
2011-02-26 3:33 ` Dan Carpenter [this message]
2011-02-26 17:13 ` KY Srinivasan
2011-03-01 2:44 ` Greg KH
2011-03-02 1:42 ` KY Srinivasan
2011-03-02 5:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110226033323.GD18043@bicker \
--to=error27@gmail.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox