* [PATCH] fs/locks.c: Remove stale FIXME left over from BKL conversion
@ 2011-02-27 13:58 Matt Fleming
2011-02-27 17:11 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Matt Fleming @ 2011-02-27 13:58 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Matthew Wilcox, Andrew Morton, linux-fsdevel, linux-kernel
From: Matt Fleming <matt.fleming@linux.intel.com>
The comment is no longer true as (now that the BKL conversion is
finished) a spinlock _is_ now used to protect file_lock_list,
blocked_list and inode->i_flock.
Signed-off-by: Matt Fleming <matt.fleming@linux.intel.com>
---
fs/locks.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 0f39982..822c3d1 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -145,7 +145,6 @@ static DEFINE_SPINLOCK(file_lock_lock);
/*
* Protects the two list heads above, plus the inode->i_flock list
- * FIXME: should use a spinlock, once lockd and ceph are ready.
*/
void lock_flocks(void)
{
--
1.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/locks.c: Remove stale FIXME left over from BKL conversion
2011-02-27 13:58 [PATCH] fs/locks.c: Remove stale FIXME left over from BKL conversion Matt Fleming
@ 2011-02-27 17:11 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2011-02-27 17:11 UTC (permalink / raw)
To: Matt Fleming; +Cc: Matthew Wilcox, Andrew Morton, linux-fsdevel, linux-kernel
On Sunday 27 February 2011, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@linux.intel.com>
>
> The comment is no longer true as (now that the BKL conversion is
> finished) a spinlock _is_ now used to protect file_lock_list,
> blocked_list and inode->i_flock.
>
> Signed-off-by: Matt Fleming <matt.fleming@linux.intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
in case anyone wants to pick it up.
Otherwise I'll queue it along with my BKL removal patches.
Thanks,
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-27 23:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-27 13:58 [PATCH] fs/locks.c: Remove stale FIXME left over from BKL conversion Matt Fleming
2011-02-27 17:11 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox