From: Greg KH <greg@kroah.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
Haiyang Zhang <haiyangz@microsoft.com>,
Hank Janssen <hjanssen@microsoft.com>
Subject: Re: [PATCH 1/6] Staging: hv: Unify hyper-v device abstractions
Date: Mon, 28 Feb 2011 18:34:49 -0800 [thread overview]
Message-ID: <20110301023449.GC1663@kroah.com> (raw)
In-Reply-To: <1298685930-30806-1-git-send-email-kys@microsoft.com>
On Fri, Feb 25, 2011 at 06:05:30PM -0800, K. Y. Srinivasan wrote:
> Hyper-V drivers have supported two device abstractions.
> This patch implements a single device abstraction.
"This patch" or "This patch series"?
> This simplifies the code and avoids duplication
> of state.
This patch is confusing, you are renaming structures (from hv_ to vm_)
which I didn't think you wanted to do.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
>
> ---
> drivers/staging/hv/blkvsc.c | 17 ++++---
> drivers/staging/hv/blkvsc_drv.c | 14 +++---
> drivers/staging/hv/channel_mgmt.c | 1 +
> drivers/staging/hv/channel_mgmt.h | 2 +-
> drivers/staging/hv/netvsc.c | 55 ++++++++++++-----------
> drivers/staging/hv/netvsc.h | 2 +-
> drivers/staging/hv/netvsc_api.h | 12 +++---
> drivers/staging/hv/netvsc_drv.c | 28 +++++-------
> drivers/staging/hv/rndis_filter.c | 19 ++++----
> drivers/staging/hv/storvsc.c | 37 ++++++++--------
> drivers/staging/hv/storvsc_api.h | 4 +-
> drivers/staging/hv/storvsc_drv.c | 21 ++++-----
> drivers/staging/hv/vmbus.h | 13 +++---
> drivers/staging/hv/vmbus_api.h | 29 ++----------
> drivers/staging/hv/vmbus_drv.c | 84 +++++++++++++++---------------------
> drivers/staging/hv/vmbus_private.h | 12 +++---
> 16 files changed, 157 insertions(+), 193 deletions(-)
>
> diff --git a/drivers/staging/hv/blkvsc.c b/drivers/staging/hv/blkvsc.c
> index 7c8729b..ecface3 100644
> --- a/drivers/staging/hv/blkvsc.c
> +++ b/drivers/staging/hv/blkvsc.c
> @@ -35,7 +35,8 @@ static const struct hv_guid g_blk_device_type = {
> }
> };
>
> -static int blk_vsc_on_device_add(struct hv_device *device, void *additional_info)
> +static int blk_vsc_on_device_add(struct vm_device *device,
> + void *additional_info)
Huh? What was this change for? 80 column issues for function
definitions is not a big deal, if any, and should not be burried in a
patch that claims to do something else.
Still totally confused,
greg k-h
next prev parent reply other threads:[~2011-03-01 5:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 2:05 [PATCH 1/6] Staging: hv: Unify hyper-v device abstractions K. Y. Srinivasan
2011-02-26 3:21 ` Steven Rostedt
2011-02-26 17:13 ` KY Srinivasan
2011-02-26 17:13 ` KY Srinivasan
2011-03-01 2:28 ` Greg KH
2011-03-01 2:34 ` Greg KH [this message]
2011-03-02 1:40 ` KY Srinivasan
2011-03-02 6:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301023449.GC1663@kroah.com \
--to=greg@kroah.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox