From: Greg KH <greg@kroah.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
Haiyang Zhang <haiyangz@microsoft.com>,
Hank Janssen <hjanssen@microsoft.com>
Subject: Re: [PATCH 5/6] Staging: hv: Rename driver_context to hyperv_driver
Date: Mon, 28 Feb 2011 18:56:40 -0800 [thread overview]
Message-ID: <20110301025640.GF1663@kroah.com> (raw)
In-Reply-To: <1298686058-30918-1-git-send-email-kys@microsoft.com>
On Fri, Feb 25, 2011 at 06:07:38PM -0800, K. Y. Srinivasan wrote:
> The title says it all.
No it doesn't. You should have done this on the last patch to keep me
from complaining about that name.
Oh, and the extra space, drop it please.
> --- a/drivers/staging/hv/blkvsc_drv.c
> +++ b/drivers/staging/hv/blkvsc_drv.c
> @@ -116,10 +116,10 @@ struct block_device_context {
> };
>
> /* Per driver */
> -struct blkvsc_driver_context {
> +struct blkvsc_hyperv_driver {
> /* !! These must be the first 2 fields !! */
> /* FIXME this is a bug! */
> - struct driver_context drv_ctx;
> + struct hyperv_driver drv_ctx;
> struct storvsc_driver_object drv_obj;
> };
>
Hey look, that Subject: and changelog body actually lied. It didn't say
it all. In fact, it didn't say enough, or you just renamed a different
structure because it felt nice.
{sigh}
One thing per patch, with full description. I'm getting tired of
repeating Documentation/CodingStyle for this subsystem when patches are
submitted.
It's as if no one even listens to me...
{sniff}
greg k-h
prev parent reply other threads:[~2011-03-01 5:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 2:07 [PATCH 5/6] Staging: hv: Rename driver_context to hyperv_driver K. Y. Srinivasan
2011-03-01 2:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301025640.GF1663@kroah.com \
--to=greg@kroah.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox