From: Greg KH <greg@kroah.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
Haiyang Zhang <haiyangz@microsoft.com>,
Hank Janssen <hjanssen@microsoft.com>
Subject: Re: [PATCH 6/6] Staging: hv: Cleanup hyperv_driver variable names
Date: Mon, 28 Feb 2011 18:58:59 -0800 [thread overview]
Message-ID: <20110301025859.GG1663@kroah.com> (raw)
In-Reply-To: <1298686078-30945-1-git-send-email-kys@microsoft.com>
On Fri, Feb 25, 2011 at 06:07:58PM -0800, K. Y. Srinivasan wrote:
> The title says it all.
That's a horrible changelog comment. So bad that I would rather see an
empty message than this one. Seriously, it give no description, and
makes us think that the whole patch is obvious, when it really isn't.
What did you change them to?
What did you change them from?
What was your motivation in changing them?
How were you feeling when the names changed?
Ok, maybe not the last one, but you get the idea.
thanks,
greg k-h
next prev parent reply other threads:[~2011-03-01 5:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 2:07 [PATCH 6/6] Staging: hv: Cleanup hyperv_driver variable names K. Y. Srinivasan
2011-02-26 3:40 ` Dan Carpenter
2011-02-26 17:13 ` KY Srinivasan
2011-03-01 2:58 ` Greg KH [this message]
2011-03-02 1:44 ` KY Srinivasan
2011-03-02 5:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301025859.GG1663@kroah.com \
--to=greg@kroah.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox