From: Arnd Bergmann <arnd@arndb.de>
To: james_p_freyensee@linux.intel.com
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
suhail.ahmed@intel.com, christophe.guerard@intel.com
Subject: Re: [PATCH 04/10] PTI Makefile and Kconfig additions.
Date: Tue, 1 Mar 2011 12:37:50 +0100 [thread overview]
Message-ID: <201103011237.50400.arnd@arndb.de> (raw)
In-Reply-To: <1298915373.3156.34.camel@localhost>
On Monday 28 February 2011, J Freyensee wrote:
> On Mon, 2011-02-28 at 10:31 +0100, Arnd Bergmann wrote:
>
> > The Kconfig description is a nice text, how about copying it to the
> > changeset so that reviewers know what the driver is about?
> >
>
> I thought patch 02/10, 'Kernel documentation', would had been first and
> met this need?
Documentation in source files is not the same as documentation in the
changelog, you need both. The changeset comments are usually just one
sentence in your series, and a little more would certainly be helpful.
Also, if you have one changeset with the documentation, that does
not help anyone who looks at another changeset.
Arnd
next prev parent reply other threads:[~2011-03-01 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 18:06 [PATCH 04/10] PTI Makefile and Kconfig additions james_p_freyensee
2011-02-28 9:31 ` Arnd Bergmann
2011-02-28 17:49 ` J Freyensee
2011-03-01 11:37 ` Arnd Bergmann [this message]
2011-03-01 17:37 ` J Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103011237.50400.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=christophe.guerard@intel.com \
--cc=gregkh@suse.de \
--cc=james_p_freyensee@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suhail.ahmed@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox