public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Youquan Song <youquan.song@linux.intel.com>
Cc: davej@redhat.com, arjan@linux.intel.com, venki@google.com,
	youquan.song@intel.com, cpufreq-list@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: Fix ondemand governor powersave_bias execution time misuse
Date: Tue, 1 Mar 2011 17:07:40 -0800	[thread overview]
Message-ID: <20110301170740.2b4a8288.akpm@linux-foundation.org> (raw)
In-Reply-To: <20101105151951.GA10743@linux-youquan.bj.intel.com>

On Fri, 5 Nov 2010 11:19:51 -0400
Youquan Song <youquan.song@linux.intel.com> wrote:

> Ondemand governor use powersave_bias tunable to do aggressive power save by
> decrease CPU average frequency. The average frequency achieve by adjust low and
> high frequency's execution time proportion during one sample time interval.  
> 
> Current kernel, only the high frequency executes in time proportion, but the low
> frequency wrongly execute in one whole sample time interval when powersave_bias
> is set.  
> 
> The patch fix it by set low frequency execution time to it deserved. 
> 
> Signed-off-by: Youquan Song <youquan.song@intel.com>
> ---
> 
> diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> index c631f27..01d84fa 100644
> --- a/drivers/cpufreq/cpufreq_ondemand.c
> +++ b/drivers/cpufreq/cpufreq_ondemand.c
> @@ -666,6 +666,8 @@ static void do_dbs_timer(struct work_struct *work)
>  	} else {
>  		__cpufreq_driver_target(dbs_info->cur_policy,
>  			dbs_info->freq_lo, CPUFREQ_RELATION_H);
> +		if (dbs_info->sample_type == DBS_SUB_SAMPLE)
> +			delay = dbs_info->freq_lo_jiffies;
>  	}
>  	queue_delayed_work_on(cpu, kondemand_wq, &dbs_info->work, delay);
>  	mutex_unlock(&dbs_info->timer_mutex);

Where are we with this patch?  Still needed in curent mainline?

Thnks.

  parent reply	other threads:[~2011-03-02  1:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-05 15:19 [PATCH] cpufreq: Fix ondemand governor powersave_bias execution time misuse Youquan Song
2010-11-05 11:49 ` Arjan van de Ven
2010-11-08 14:45   ` Youquan Song
2010-11-08  4:32     ` Arjan van de Ven
2011-03-02  1:07 ` Andrew Morton [this message]
2011-03-02 18:58   ` Youquan Song
2011-03-02 16:00     ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110301170740.2b4a8288.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=cpufreq-list@vger.kernel.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venki@google.com \
    --cc=youquan.song@intel.com \
    --cc=youquan.song@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox