From: Greg KH <greg@kroah.com>
To: "Allyn, Mark A" <mark.a.allyn@intel.com>
Cc: "Mangalampalli, Jayant" <jayant.mangalampalli@intel.com>,
"Gokulrangan, Venkat R" <venkat.r.gokulrangan@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alan@linux.intel.com" <alan@linux.intel.com>
Subject: Re: RFC: [PATCH 0/5] staging: sep: Enable kernel crypto
Date: Tue, 1 Mar 2011 16:23:50 -0500 [thread overview]
Message-ID: <20110301212350.GA22953@kroah.com> (raw)
In-Reply-To: <8A0E4C92AE2D6D40AF99653191DA3231614A0A654E@rrsmsx501.amr.corp.intel.com>
On Tue, Mar 01, 2011 at 02:10:09PM -0700, Allyn, Mark A wrote:
> Greg writes:
>
> Why? What does this mean to me? To users? You need to sell this new
> feature to me a LOT before I will take it as I really want and need to
> see this driver fixed up first before you can add new features to it.
>
> thanks,
>
> greg k-h
>
>
> =================
>
> Greg:
>
> I agree; I will work on getting the current core driver out of staging prior to making the kernel crypto changes.
First off, please fix your email client to do proper quoting and wrap
lines at 72 columns. Even Outlook can do this so there really is no
excuse anymore...
>
> What are the major issues with the core driver? I know about the current items in the TODO list having to do with the unused ioctl calls and structures.
>
> What other issues are there?
That's a good place to start, fix those up and when you feel you have
addressed everything, ask for a review of the code and we can go from
there.
thanks,
greg k-h
prev parent reply other threads:[~2011-03-01 21:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 5:10 RFC: [PATCH 0/5] staging: sep: Enable kernel crypto Mark Allyn
2011-02-28 14:15 ` Greg KH
2011-02-28 17:31 ` Allyn, Mark A
2011-02-28 21:20 ` Greg KH
2011-03-01 21:10 ` Allyn, Mark A
2011-03-01 21:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301212350.GA22953@kroah.com \
--to=greg@kroah.com \
--cc=alan@linux.intel.com \
--cc=jayant.mangalampalli@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.a.allyn@intel.com \
--cc=venkat.r.gokulrangan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox