* RFC: [PATCH 0/5] staging: sep: Enable kernel crypto
@ 2011-02-28 5:10 Mark Allyn
2011-02-28 14:15 ` Greg KH
2011-02-28 21:20 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Mark Allyn @ 2011-02-28 5:10 UTC (permalink / raw)
To: linux-kernel, greg, mark.a.allyn, alan
This is a set of 5 patches to enable kernel crypto operation of the
SEP device
All patches are required as a set.
Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFC: [PATCH 0/5] staging: sep: Enable kernel crypto
2011-02-28 5:10 RFC: [PATCH 0/5] staging: sep: Enable kernel crypto Mark Allyn
@ 2011-02-28 14:15 ` Greg KH
2011-02-28 17:31 ` Allyn, Mark A
2011-02-28 21:20 ` Greg KH
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2011-02-28 14:15 UTC (permalink / raw)
To: Mark Allyn; +Cc: linux-kernel, alan
On Sun, Feb 27, 2011 at 09:10:24PM -0800, Mark Allyn wrote:
> This is a set of 5 patches to enable kernel crypto operation of the
> SEP device
>
> All patches are required as a set.
>
> Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Is this really a "request for comments" set of patches, or do you want
me to apply them to my tree?
confused,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: RFC: [PATCH 0/5] staging: sep: Enable kernel crypto
2011-02-28 14:15 ` Greg KH
@ 2011-02-28 17:31 ` Allyn, Mark A
0 siblings, 0 replies; 6+ messages in thread
From: Allyn, Mark A @ 2011-02-28 17:31 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com
Is this really a "request for comments" set of patches, or do you want
me to apply them to my tree?
confused,
greg k-h
Greg:
This was meant to be request for comment so that I can make any necessary
Changes prior to submitting it for the tree.
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFC: [PATCH 0/5] staging: sep: Enable kernel crypto
2011-02-28 5:10 RFC: [PATCH 0/5] staging: sep: Enable kernel crypto Mark Allyn
2011-02-28 14:15 ` Greg KH
@ 2011-02-28 21:20 ` Greg KH
2011-03-01 21:10 ` Allyn, Mark A
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2011-02-28 21:20 UTC (permalink / raw)
To: Mark Allyn; +Cc: linux-kernel, alan
On Sun, Feb 27, 2011 at 09:10:24PM -0800, Mark Allyn wrote:
> This is a set of 5 patches to enable kernel crypto operation of the
> SEP device
Why? What does this mean to me? To users? You need to sell this new
feature to me a LOT before I will take it as I really want and need to
see this driver fixed up first before you can add new features to it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: RFC: [PATCH 0/5] staging: sep: Enable kernel crypto
2011-02-28 21:20 ` Greg KH
@ 2011-03-01 21:10 ` Allyn, Mark A
2011-03-01 21:23 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Allyn, Mark A @ 2011-03-01 21:10 UTC (permalink / raw)
To: Greg KH, Mangalampalli, Jayant, Gokulrangan, Venkat R
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com
Greg writes:
Why? What does this mean to me? To users? You need to sell this new
feature to me a LOT before I will take it as I really want and need to
see this driver fixed up first before you can add new features to it.
thanks,
greg k-h
=================
Greg:
I agree; I will work on getting the current core driver out of staging prior to making the kernel crypto changes.
What are the major issues with the core driver? I know about the current items in the TODO list having to do with the unused ioctl calls and structures.
What other issues are there?
Thanks
Mark Allyn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFC: [PATCH 0/5] staging: sep: Enable kernel crypto
2011-03-01 21:10 ` Allyn, Mark A
@ 2011-03-01 21:23 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2011-03-01 21:23 UTC (permalink / raw)
To: Allyn, Mark A
Cc: Mangalampalli, Jayant, Gokulrangan, Venkat R,
linux-kernel@vger.kernel.org, alan@linux.intel.com
On Tue, Mar 01, 2011 at 02:10:09PM -0700, Allyn, Mark A wrote:
> Greg writes:
>
> Why? What does this mean to me? To users? You need to sell this new
> feature to me a LOT before I will take it as I really want and need to
> see this driver fixed up first before you can add new features to it.
>
> thanks,
>
> greg k-h
>
>
> =================
>
> Greg:
>
> I agree; I will work on getting the current core driver out of staging prior to making the kernel crypto changes.
First off, please fix your email client to do proper quoting and wrap
lines at 72 columns. Even Outlook can do this so there really is no
excuse anymore...
>
> What are the major issues with the core driver? I know about the current items in the TODO list having to do with the unused ioctl calls and structures.
>
> What other issues are there?
That's a good place to start, fix those up and when you feel you have
addressed everything, ask for a review of the code and we can go from
there.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-01 21:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-28 5:10 RFC: [PATCH 0/5] staging: sep: Enable kernel crypto Mark Allyn
2011-02-28 14:15 ` Greg KH
2011-02-28 17:31 ` Allyn, Mark A
2011-02-28 21:20 ` Greg KH
2011-03-01 21:10 ` Allyn, Mark A
2011-03-01 21:23 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox