public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ted Ts'o" <tytso@mit.edu>
To: richard -rw- weinberger <richard.weinberger@gmail.com>
Cc: dj@deadhat.com, linux-kernel@vger.kernel.org, gregkh@suse.de
Subject: Re: Why is my copyright code in the linux kernel?
Date: Tue, 1 Mar 2011 18:54:33 -0500	[thread overview]
Message-ID: <20110301235433.GD2959@thunk.org> (raw)
In-Reply-To: <AANLkTimg1x56B4Yu=Zsd0VEci2i4jRKaMU+gxv3oFVr8@mail.gmail.com>

On Wed, Mar 02, 2011 at 12:30:45AM +0100, richard -rw- weinberger wrote:
> > You will see a remarkable resemblance to parts of
> > linux-2.6.36.2/drivers/staging/rt2860/common/cmm_aes.c. E.G. the AES code,
> 
> please note, this is a staging driver.

It's not even the primary driver.  Is there anything that this driver
provides that isn't provided by the upstream supported, mainline
rt2x00 project?  I.e., can we just delete the staging driver?

If we are going to keep the staging driver for some reason, one of the
things that should be added to the TODO list would be delete its
driver-specific AES code and replace it with calls to the kernel's
generic AES code, which among other things, has the advantage that it
can take advantage of the AES-NI instructions provided on more modern
x86 CPU's.

> > I'd like to know who is an appropriate person to discuss this with.
> 
> the code is from ralink.

David, you might want to contact ralink directly, since it's likely
they are distributing that driver with your AES code in other places
besides just in the mainstream kernel sources.  Even if we delete the
code in the staging tree, they might be distributing that driver still
via other means.

Regards,

						- Ted

  reply	other threads:[~2011-03-01 23:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 22:49 Why is my copyright code in the linux kernel? dj
2011-03-01 23:30 ` richard -rw- weinberger
2011-03-01 23:54   ` Ted Ts'o [this message]
2011-03-02 21:52     ` H. Peter Anvin
2011-03-03  6:04       ` Greg KH
2011-03-04  5:29       ` David Johnston
2011-03-04  6:34         ` H. Peter Anvin
2011-03-04 22:16           ` Yinghai Lu
2011-03-04 22:19             ` H. Peter Anvin
     [not found]     ` <56a24cfecea63a4752f441056da9c813.squirrel@deadhat.com>
2011-03-03  4:03       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110301235433.GD2959@thunk.org \
    --to=tytso@mit.edu \
    --cc=dj@deadhat.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard.weinberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox