From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Tom Zanussi <tzanussi@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] perf: Set filters before mmaping events
Date: Wed, 2 Mar 2011 09:49:25 +0100 [thread overview]
Message-ID: <20110302084925.GA21204@elte.hu> (raw)
In-Reply-To: <1298693021-23500-1-git-send-email-fweisbec@gmail.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> We currently set the filters after we mmap the events, this is a
> race that let undesired events record themselves in the buffer before
> we had the time to set the filters.
>
> So set the filters before they can be recorded. That also librarizes
> the filters setting so that filtering can be done more easily
> from other tools than perf record later.
>
> (PS: This should fix most of the bugs Ingo has reported
> about filters that weren't working with perf).
Nice!
Mind pulling Steve's filter-enhancements branch and sending a pull request for the
whole thing? Steve's branch was:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git tip/perf/filter
( Or your fixes could be applied to Steve's branch as well - whichever direction you
guys prefer - the important thing is to have filtering tested and validated as a
whole. )
Thanks,
Ingo
next prev parent reply other threads:[~2011-03-02 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 4:03 [PATCH] perf: Set filters before mmaping events Frederic Weisbecker
2011-03-02 8:49 ` Ingo Molnar [this message]
2011-03-03 3:51 ` [GIT PULL] tracepoints filtering updates Frederic Weisbecker
2011-03-03 7:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302084925.GA21204@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox