From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757350Ab1CBTj7 (ORCPT ); Wed, 2 Mar 2011 14:39:59 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:65313 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756515Ab1CBTj6 convert rfc822-to-8bit (ORCPT ); Wed, 2 Mar 2011 14:39:58 -0500 Date: Wed, 2 Mar 2011 11:37:10 -0800 From: Randy Dunlap To: Chen Liu Cc: linux-kernel@vger.kernel.org, scsi Subject: Re: [Patch] Patch for bug 13547 Message-Id: <20110302113710.f63fd8ee.randy.dunlap@oracle.com> In-Reply-To: References: Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.4D6E9D0A.00FC,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Mar 2011 14:28:51 -0500 Chen Liu wrote: [adding linux-scsi] > Hi everyone, > > There is a patch generated by the tool R2Fix for bug 13547. Could you > take a look at them? Thanks! > The patch: > --- linux-2.6.30/drivers/scsi/FlashPoint.c    2009-06-09 > 23:05:27.000000000 -0400 > +++ /tmp/cocci-output-726-34f8c9-FlashPoint.c    2011-02-23 > 22:05:29.765164083 -0500 > @@ -1212,7 +1212,7 @@ static unsigned long FlashPoint_Hardware > >      ioport = pCardInfo->si_baseaddr; > > -    for (thisCard = 0; thisCard <= MAX_CARDS; thisCard++) { > +    for (thisCard = 0; thisCard < MAX_CARDS; thisCard++) { > >          if (thisCard == MAX_CARDS) { Please fix the R2Fix tool to generate patches correctly: The +++ file name is incorrect. The patch is whitespace-damaged. gmail isn't good at preserving tabs -- they have been converted to spaces, so the patch does not apply cleanly. If this patch is applied, how does this function return FAILURE? I don't think that is does -- I think the patch is bad. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***