public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] Reverting NUMA-affine page table allocation
Date: Wed, 2 Mar 2011 17:19:00 +0100	[thread overview]
Message-ID: <20110302161900.GP3319@htj.dyndns.org> (raw)
In-Reply-To: <AANLkTinW-nQV4tL-_PicOb-N6imv3gtWuG-J69-6VUQd@mail.gmail.com>

Hey, Yinghai.

On Tue, Mar 01, 2011 at 02:41:55PM -0800, Yinghai Lu wrote:
> > 2. find_early_table_space() always calculates the amount of the needed
> >   space from 0 to the specified @end.  As nodes are registered, each
> >   node would try to allocate accumulative amount of space for page
> >   table.  This probably wouldn't cause any actual problem (may affect
> >   emulated configurations a bit tho).
> 
> interesting.

Yeah, it's a pretty interesting piece of code in need of some cleanup.

I'm reverting the NUMA-affine page table allocation for now.  I wish
something like the following happens during the next devel cycle.

* General cleanup of page table allocation code.  I'm not talking
  about major rewrite or anything major.  Just making the code sane(r)
  so that they take parameters instead of doing subtle stuff with
  internal #ifdef's.  And hopefully proper documentation.

* Redo the NUMA-affine page table allocation in simpler way using
  cleaned up allocation functions.  As suggested before, IMO, just
  taking top and bottom of nodes is enough.  Again, hopefully, with
  enough documentation on both what and why.

If you're interested in doing the above, please go ahead and let me
know.

Thank you.

-- 
tejun

  reply	other threads:[~2011-03-02 16:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-26 14:37 [RFC] Reverting NUMA-affine page table allocation Tejun Heo
2011-03-01  8:30 ` Tejun Heo
2011-03-01 22:41 ` Yinghai Lu
2011-03-02 16:19   ` Tejun Heo [this message]
2011-03-02 16:47     ` Yinghai Lu
2011-03-02 17:07       ` Tejun Heo
2011-03-02 18:08         ` Ingo Molnar
2011-03-02 18:12           ` H. Peter Anvin
2011-03-02 18:19             ` Ingo Molnar
2011-03-02 18:25               ` Tejun Heo
2011-03-02 18:31                 ` Ingo Molnar
2011-03-02 18:32               ` Ingo Molnar
2011-03-02 18:22           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110302161900.GP3319@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox