Re: [PATCH 01/22] sched: Provide scheduler_ipi() callback in response to smp_send_reschedule()

Peter Zijlstra
2011-03-16T08:28:42Z

On Thu, 2011-03-10 at 17:36 -0800, Frank Rowand wrote:
>
> > Index: linux-2.6/arch/sparc/kernel/smp_32.c
> > ===================================================================
> > --- linux-2.6.orig/arch/sparc/kernel/smp_32.c
> > +++ linux-2.6/arch/sparc/kernel/smp_32.c
> > @@ -125,7 +125,7 @@ struct linux_prom_registers smp_penguin_
> >
> > void smp_send_reschedule(int cpu)
> > {
> > - /* See sparc64 */
> > + scheduler_ipi();
> > }
>
> If I understand correctly, this is calling scheduler_ipi() on the
> cpu that should be sending an IPI, not on the cpu receiving the IPI.
> If so, smp_send_reschedule() needs to send an IPI, and the scheduler_ipi()
> put in the place where the IPI is processed.

Yes, D'0h.. Dave how does sparc32 work here? There appears to be an ipi
missing.